Page MenuHomePhabricator

As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers
ClosedPublic

Authored by epriestley on Feb 23 2018, 7:12 PM.
Tags
None
Referenced Files
F14090103: D19139.diff
Sun, Nov 24, 3:44 PM
Unknown Object (File)
Tue, Nov 19, 1:52 AM
Unknown Object (File)
Thu, Nov 14, 6:49 PM
Unknown Object (File)
Fri, Nov 1, 8:38 PM
Unknown Object (File)
Oct 23 2024, 8:56 PM
Unknown Object (File)
Oct 14 2024, 6:38 AM
Unknown Object (File)
Oct 9 2024, 9:02 AM
Unknown Object (File)
Oct 9 2024, 9:02 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19138. Ref T13088. When we want to read the last part of a logfile and show accurate line numbers, we need to be able to get from byte offsets to line numbers somehow.

Our fundamental unit must remain byte offsets, because a test can emit an arbitrarily long line, and we should accommodate it cleanly if a test emits 2GB of the letter "A".

To support going from byte offsets to line numbers, compute a map with periodic line markers throughout the offsets of the file. From here, we can figure out the line numbers for arbitrary positions in the file with only a constant amount of work.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 7:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:57 AM
This revision was automatically updated to reflect the committed changes.