Page MenuHomePhabricator

As Harbormaster logs are processed, build a sparse map of byte offsets to line numbers
ClosedPublic

Authored by epriestley on Feb 23 2018, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 12:50 PM
Unknown Object (File)
Tue, Jan 28, 3:26 AM
Unknown Object (File)
Sat, Jan 25, 12:22 AM
Unknown Object (File)
Sat, Jan 25, 12:22 AM
Unknown Object (File)
Sat, Jan 25, 12:22 AM
Unknown Object (File)
Tue, Jan 21, 11:21 AM
Unknown Object (File)
Wed, Jan 8, 2:26 PM
Unknown Object (File)
Dec 28 2024, 3:17 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19138. Ref T13088. When we want to read the last part of a logfile and show accurate line numbers, we need to be able to get from byte offsets to line numbers somehow.

Our fundamental unit must remain byte offsets, because a test can emit an arbitrarily long line, and we should accommodate it cleanly if a test emits 2GB of the letter "A".

To support going from byte offsets to line numbers, compute a map with periodic line markers throughout the offsets of the file. From here, we can figure out the line numbers for arbitrary positions in the file with only a constant amount of work.

Test Plan

Added unit tests; ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
hlog10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19654
Build 26616: Run Core Tests
Build 26615: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 7:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:57 AM
This revision was automatically updated to reflect the committed changes.