Tags

None

Referenced Files

	F15489400: D19135.id45856.diff
	Fri, Apr 11, 8:39 AM

	F15489327: D19135.id45841.diff
	Fri, Apr 11, 7:57 AM

	F15486213: D19135.id.diff
	Thu, Apr 10, 5:40 AM

	F15483061: D19135.diff
	Wed, Apr 9, 9:39 AM

	F15477278: D19135.id45856.diff
	Mon, Apr 7, 1:14 PM

	F15469687: D19135.id45841.diff
	Fri, Apr 4, 3:34 PM

	F15425482: D19135.diff
	Sun, Mar 23, 4:47 AM

	F15424048: D19135.id45841.diff
	Sat, Mar 22, 7:59 PM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rPd152bd583608: Manage log locks on the Log object to prepare for multiple writers

Summary

Depends on D19134. Ref T13088. Future changes will support API writers, so push the log lock into the Log object.

Allow open/close ("this process is writing to this log") to be separate from live/final ("this log is still generating more data").

Test Plan

Wrote logs with bin/harbormater write-log and updated logs with bin/harbormaster rebuild-log.

Diff Detail

Repository

rP Phabricator

Branch

hlog6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/harbormaster/storage/build/HarbormasterBuildLog.php:309	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 19650
Build 26608: Run Core Tests
Build 26607: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 1:39 PM

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:39 PM

Harbormaster completed remote builds in B19650: Diff 45841.Feb 23 2018, 1:41 PM

epriestley requested review of this revision.Feb 23 2018, 1:41 PM

epriestley added a child revision: D19136: In Harbormaster, record byte length on the build logs.Feb 23 2018, 1:52 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:54 AM

Closed by commit rPd152bd583608: Manage log locks on the Log object to prepare for multiple writers (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Manage log locks on the Log object to prepare for multiple writers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45841

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Manage log locks on the Log object to prepare for multiple writersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45841

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Manage log locks on the Log object to prepare for multiple writers
ClosedPublic
Actions

Revision Contents
Changeset List