Page MenuHomePhabricator
Differential D19135

Manage log locks on the Log object to prepare for multiple writers
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 11:06 PM
Unknown Object (File)
Sat, Nov 16, 7:45 AM
Unknown Object (File)
Tue, Nov 12, 10:12 AM
Unknown Object (File)
Fri, Nov 8, 11:18 AM
Unknown Object (File)
Mon, Nov 4, 5:11 PM
Unknown Object (File)
Fri, Nov 1, 7:42 PM
Unknown Object (File)
Tue, Oct 29, 6:03 PM
Unknown Object (File)
Oct 19 2024, 4:23 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPd152bd583608: Manage log locks on the Log object to prepare for multiple writers
Summary

Depends on D19134. Ref T13088. Future changes will support API writers, so push the log lock into the Log object.

Allow open/close ("this process is writing to this log") to be separate from live/final ("this log is still generating more data").

Test Plan

Wrote logs with bin/harbormater write-log and updated logs with bin/harbormaster rebuild-log.

Diff Detail

Repository
rP Phabricator
Branch
hlog6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/storage/build/HarbormasterBuildLog.php:309XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19650
Build 26608: Run Core Tests
Build 26607: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 1:39 PM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:39 PM
Harbormaster completed remote builds in B19650: Diff 45841.Feb 23 2018, 1:41 PM
epriestley requested review of this revision.Feb 23 2018, 1:41 PM
epriestley added a child revision: D19136: In Harbormaster, record byte length on the build logs.Feb 23 2018, 1:52 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:54 AM
Closed by commit rPd152bd583608: Manage log locks on the Log object to prepare for multiple writers (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
storage/
build/
261 lines
worker/
26 lines

Diff 45841

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Loading...
Phabricator · Built by Phacility