Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F14842576: D19131.diff
Sun, Feb 2, 12:19 AM
Unknown Object (File)
Thu, Jan 30, 2:30 PM
Unknown Object (File)
Tue, Jan 28, 3:25 AM
Unknown Object (File)
Sat, Jan 25, 9:15 PM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Sat, Jan 25, 12:20 AM
Unknown Object (File)
Fri, Jan 24, 11:17 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Branch
hlog2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19646
Build 26600: Run Core Tests
Build 26599: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.