Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F15490918: D19131.id45852.diff
Fri, Apr 11, 9:42 PM
F15488830: D19131.id45837.diff
Fri, Apr 11, 3:14 AM
F15488119: D19131.id.diff
Thu, Apr 10, 7:40 PM
F15483535: D19131.diff
Wed, Apr 9, 12:56 PM
F15339290: D19131.diff
Mar 9 2025, 2:41 PM
F15282802: D19131.id45837.diff
Mar 4 2025, 2:33 AM
Unknown Object (File)
Feb 26 2025, 3:58 AM
Unknown Object (File)
Feb 23 2025, 10:02 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Branch
hlog2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19646
Build 26600: Run Core Tests
Build 26599: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.