Page MenuHomePhabricator

Move Harbormaster log compression to the worker task queue
ClosedPublic

Authored by epriestley on Feb 23 2018, 2:20 AM.
Tags
None
Referenced Files
F18813198: D19131.diff
Mon, Oct 20, 2:34 PM
F18812190: D19131.id45837.diff
Mon, Oct 20, 7:35 AM
F18810053: D19131.id.diff
Sun, Oct 19, 7:07 PM
F18809249: D19131.id45852.diff
Sun, Oct 19, 12:18 PM
F18738226: D19131.diff
Wed, Oct 1, 2:52 PM
F18566626: D19131.id.diff
Sep 9 2025, 2:47 PM
F18502215: D19131.diff
Sep 4 2025, 10:17 PM
F18379892: D19131.id45852.diff
Aug 28 2025, 4:48 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19130. Ref T13088. Currently, when a build log is closed we compress it in the same process. Separate this out into a dedicated worker since the plan is to do a lot more work during finalization, none of which needs to happen inline during builds (or, particuarly, inline during a Conduit call for API writes in the future).

Test Plan

Ran bin/harbormaster write-log --trace, saw compression run inline.

Diff Detail

Repository
rP Phabricator
Branch
hlog2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19646
Build 26600: Run Core Tests
Build 26599: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:20 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:52 AM
This revision was automatically updated to reflect the committed changes.