Differential D19022

Fix an issue where some Differential edit pathways may not have reviewers attached
ClosedPublic
Actions

Authored by epriestley on Feb 7 2018, 5:42 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13053: Plans: Mail Tags and Failover

Commits

rPd0a2e3c54f9a: Fix an issue where some Differential edit pathways may not have reviewers…

Summary

Depends on D19021. Ref T13053. When you "Subscribe", or make some other types of edits, we don't necessarily have reviewer data, but may now need it to do the new recipient list logic.

I don't have a totally clean way to deal with this in the general case in mind, but just load it for now so that things don't fatal.

Test Plan

Subscribed to a revision with the "Subscribe" action.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 7 2018, 5:42 PM

Harbormaster completed remote builds in B19385: Diff 45591.Feb 7 2018, 5:43 PM

epriestley requested review of this revision.Feb 7 2018, 5:43 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:30 PM

Closed by commit rPd0a2e3c54f9a: Fix an issue where some Differential edit pathways may not have reviewers… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rPc64aae052ff6: Make sure auditors are attached to commits on new pathways.Feb 10 2018, 1:09 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

25 lines

storage/

DifferentialRevision.php

4 lines

Diff 45617

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php