Page MenuHomePhabricator

Fix an issue where some Differential edit pathways may not have reviewers attached
ClosedPublic

Authored by epriestley on Feb 7 2018, 5:42 PM.
Tags
None
Referenced Files
F13239241: D19022.diff
Wed, May 22, 1:21 AM
F13227209: D19022.diff
Mon, May 20, 1:44 AM
F13221321: D19022.diff
Sun, May 19, 2:29 AM
F13184967: D19022.diff
Sat, May 11, 2:08 AM
Unknown Object (File)
Tue, May 7, 1:55 AM
Unknown Object (File)
Tue, May 7, 12:24 AM
Unknown Object (File)
Mon, May 6, 8:25 AM
Unknown Object (File)
Fri, May 3, 2:53 AM
Subscribers
None

Details

Summary

Depends on D19021. Ref T13053. When you "Subscribe", or make some other types of edits, we don't necessarily have reviewer data, but may now need it to do the new recipient list logic.

I don't have a totally clean way to deal with this in the general case in mind, but just load it for now so that things don't fatal.

Test Plan

Subscribed to a revision with the "Subscribe" action.

Diff Detail

Repository
rP Phabricator
Branch
mailer19
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19385
Build 26220: Run Core Tests
Build 26219: arc lint + arc unit