Details
Details
Tried to set it to various bad values, got reasonable error messages. Read documentation.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mailer4
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 19395 Build 26234: Run Core Tests Build 26233: arc lint + arc unit
Event Timeline
Comment Actions
Mostly minor nitpicks, but the last one is a real bug.
| src/docs/user/configuration/configuring_outbound_email.diviner | ||
|---|---|---|
| 81 | "option which" | |
| 132–133 | Should we also add a note about needing to toggle that "actually send emails as expected" option? | |
| 246–248 | It's not totally obvious that numerically higher priorities are preferred. Maybe explicitly add priority: 200 for the above example? | |
| src/infrastructure/cluster/config/PhabricatorClusterMailersConfigType.php | ||
| 51 | "invalid specification" (or "invalid mailer specification"). | |
| 81 | "Supported" | |
| 94 | Missing $key. | |
Comment Actions
- Fix typos/wordsmithing.
- Make it more clear that priorities go from high to low, not "1st priority, 2nd priority".