Paths

Table of Contentst

Differential D19940

Remove all legacy configuration options for mailers
ClosedPublic
Actions

Authored by epriestley on Jan 2 2019, 4:24 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T920: Provide SMS Support

Commits

rP9d5b933ed5a3: Remove all legacy configuration options for mailers

Summary

Ref T920. About a year ago (in 2018 Week 6, see D19003) we moved from individually configured mailers to cluster.mailers, primarily to support fallback across multiple mail providers.

Since this has been stable for quite a while, drop support for the older options.

Test Plan

Grepped for all removed options.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Slightly tidier change.

Harbormaster completed remote builds in B21456: Diff 47602.Jan 2 2019, 4:25 AM

Harbormaster completed remote builds in B21457: Diff 47603.

epriestley requested review of this revision.Jan 2 2019, 4:26 AM

amckinley accepted this revision.Jan 3 2019, 12:32 AM

This revision is now accepted and ready to land.Jan 3 2019, 12:32 AM

Closed by commit rP9d5b933ed5a3: Remove all legacy configuration options for mailers (authored by epriestley). · Explain WhyJan 3 2019, 12:09 PM

This revision was automatically updated to reflect the committed changes.

amckinley mentioned this in D19964: Resurrect setup check for cluster.mailers.Jan 11 2019, 10:27 PM

amckinley mentioned this in rPb98d46ce7d28: Resurrect setup check for cluster.mailers.Jan 16 2019, 8:14 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

config/

check/

PhabricatorExtraConfigSetupCheck.php

26 lines

PhabricatorMailSetupCheck.php

option/

PhabricatorAWSConfigOptions.php

18 lines

PhabricatorMailgunConfigOptions.php

PhabricatorMetaMTAConfigOptions.php

7 lines

PhabricatorPHPMailerConfigOptions.php

PhabricatorSendGridConfigOptions.php

metamta/

adapter/

PhabricatorMailImplementationAdapter.php

1 line

PhabricatorMailImplementationAmazonSESAdapter.php

9 lines

PhabricatorMailImplementationMailgunAdapter.php

7 lines

PhabricatorMailImplementationPHPMailerAdapter.php

12 lines

PhabricatorMailImplementationPHPMailerLiteAdapter.php

6 lines

PhabricatorMailImplementationPostmarkAdapter.php

4 lines

PhabricatorMailImplementationSendGridAdapter.php

16 lines

PhabricatorMailImplementationTestAdapter.php

4 lines

storage/

PhabricatorMetaMTAMail.php

65 lines

docs/

user/

configuration/

configuration_locked.diviner

2 lines

configuring_inbound_email.diviner

2 lines

Diff 47613

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

View Options

src/applications/config/check/PhabricatorMailSetupCheck.php

View Options

src/applications/config/option/PhabricatorAWSConfigOptions.php

View Options

src/applications/config/option/PhabricatorMailgunConfigOptions.php

View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

View Options

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

View Options

src/applications/config/option/PhabricatorSendGridConfigOptions.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationAmazonSESAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerLiteAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPostmarkAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

View Options

src/docs/user/configuration/configuration_locked.diviner

View Options

src/docs/user/configuration/configuring_inbound_email.diviner

Remove all legacy configuration options for mailersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47613

src/__phutil_library_map__.php

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

src/applications/config/check/PhabricatorMailSetupCheck.php

src/applications/config/option/PhabricatorAWSConfigOptions.php

src/applications/config/option/PhabricatorMailgunConfigOptions.php

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

src/applications/config/option/PhabricatorSendGridConfigOptions.php

src/applications/metamta/adapter/PhabricatorMailImplementationAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationAmazonSESAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerLiteAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationPostmarkAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationSendGridAdapter.php

src/applications/metamta/adapter/PhabricatorMailImplementationTestAdapter.php

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

src/docs/user/configuration/configuration_locked.diviner

src/docs/user/configuration/configuring_inbound_email.diviner

Remove all legacy configuration options for mailers
ClosedPublic
Actions

Revision Contents
Changeset List