Ref T7604. Change two migrations to query arcanist project information using queryfx directly to avoid the need for the LiskDAO fields to exist.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7604: Remove "Arcanist Projects"
- Commits
- Restricted Diffusion Commit
rP7bea116b0045: Change migrations to not rely on "arcanist project" classes
Ran the following commands to verify that things weren't majorly broken:
- ./bin/storage upgrade --apply phabricator:20150503.repositorysymbols.2.php
- ./bin/storage upgrade --no-quickstart --namespace test
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6394 Build 6416: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think 131.migraterevisionquery.php is so old (circa 2012) that we can simply drop support for it (leave a comment pointing at T7604 and delete the migration body). The effect of missing the migration is very small and the number of affected installs is likely 0 (active installs created in 2012 that haven't updated in more than 3 years).
For the other patch, you can partially test it like this:
$ bin/storage upgrade --apply phabricator:20150503.repositorysymbols.2.phpThat will re-run; it may not do much, but it will at least catch major query/syntax errors.
You can also re-run all patches in sequence like this:
$ bin/storage upgrade --no-quickstart --namespace test1234You may want to bin/storage destroy the namespace afterward.
These may not catch everything, but should catch big/obvious stuff, at least.