Page MenuHomePhabricator

[Draft] Remove arcanist projects
AbandonedPublic

Authored by joshuaspence on May 6 2015, 11:58 AM.
Tags
None
Referenced Files
F14406630: D12733.diff
Mon, Dec 23, 5:45 PM
Unknown Object (File)
Sun, Dec 22, 9:23 AM
Unknown Object (File)
Fri, Dec 20, 1:41 AM
Unknown Object (File)
Thu, Dec 5, 4:13 PM
Unknown Object (File)
Tue, Dec 3, 2:37 PM
Unknown Object (File)
Wed, Nov 27, 3:13 AM
Unknown Object (File)
Tue, Nov 26, 2:19 PM
Unknown Object (File)
Nov 22 2024, 9:14 AM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7604: Remove "Arcanist Projects"
Summary

Fixes T7604.

Test Plan

This is just a draft to give me an idea of what else is left.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 5794
Build 5813: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to [Draft] Remove arcanist projects.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

I'd like to do this in two phases:

  1. Stop all reads and writes, but don't destroy any data yet.
  2. Some time later, destroy data.

As written, this patch is not reversible (it permanently destroys data) and limits our ability to recover if we get things wrong or miss edge cases.

Three things I'd like to see covered by the test plan:

  1. How broken is Releeph after this? I can help you assess this if you aren't sure.
  2. What happens when Herald rules that use "Arcanist Projects" conditions run? I'd like to confirm it is approximately "the rule fails, but evaluation of other rules continues".
  3. Is arc happy about this change, or does it expect, e.g., arcanistProjectPHID to exist in the Conduit response?
This revision now requires changes to proceed.May 17 2015, 3:01 PM

Splitting this up into smaller diffs.