Fixes T7604.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7604: Remove "Arcanist Projects"
This is just a draft to give me an idea of what else is left.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 5794 Build 5813: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I'd like to do this in two phases:
- Stop all reads and writes, but don't destroy any data yet.
- Some time later, destroy data.
As written, this patch is not reversible (it permanently destroys data) and limits our ability to recover if we get things wrong or miss edge cases.
Three things I'd like to see covered by the test plan:
- How broken is Releeph after this? I can help you assess this if you aren't sure.
- What happens when Herald rules that use "Arcanist Projects" conditions run? I'd like to confirm it is approximately "the rule fails, but evaluation of other rules continues".
- Is arc happy about this change, or does it expect, e.g., arcanistProjectPHID to exist in the Conduit response?