Page MenuHomePhabricator

When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:59 PM.
Tags
None
Referenced Files
F19469907: D16436.id39527.diff
Mon, Jan 5, 6:12 AM
F18892988: D16436.id.diff
Nov 7 2025, 12:29 PM
F18877136: D16436.diff
Nov 6 2025, 6:18 AM
F18872314: D16436.diff
Nov 5 2025, 3:33 AM
F18790631: D16436.id39527.diff
Oct 15 2025, 4:09 PM
F18630357: D16436.id39527.diff
Sep 16 2025, 11:28 AM
F18630354: D16436.id39527.diff
Sep 16 2025, 11:28 AM
F18630197: D16436.id39542.diff
Sep 16 2025, 10:59 AM
Subscribers
None

Details

Summary

Ref T11522. When a commit is no longer reachable from any branch/tag, we currently show a "this has been deleted" message.

Instead, go further: check if there is a "rewritten" hint pointing at a commit the current commit was rewritten into. If we find one, show a message about that instead.

(This isn't super pretty, just getting it working for now. I expect to revisit this UI in T9713 if we don't get to it before that.)

Test Plan

Screen Shot 2016-08-24 at 5.55.21 AM.png (1×1 px, 208 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When a commit has a "rewritten" hint, show it in the UI instead of the generic "deleted" message.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 4:03 PM
This revision was automatically updated to reflect the committed changes.