Page MenuHomePhabricator
Create Task
Maniphest T7585

Implement view/join rules for rooms
Closed, ResolvedPublic
Actions

Description

  • When viewing a room that you don't have permission to join, you shouldn't have an option to send a message.
  • When viewing a room that you have permission to join -- but are not a member of -- sending a message should join the room (make you a member of the thread). Ideally, the UI button should change from "Send Message" to "Join Room" or something, but this could be a future version.
  • When viewing a room that you are a member of, chat should work normally.

Revisions and Commits

rP Phabricator
D12149rP25767096c931 Conpherence - implement join / view rules for rooms

Related Objects
Search...

StatusAssignedTask
 OpenNoneT7569 Support Feed/Notifications in Conpherence
 ResolvedbtrahanT7565 Ship Conpherence v2
 ResolvedbtrahanT7572 Ship Durable Chat Column
 OpenNoneT7589 Decide on pinning, sorting, and notification behaviors in icon switcher
 WontfixchadT7588 Provide UI to let users switch to threads/rooms other than the 6 most recent
 OpenNoneT7577 Improve username mention rules for Conpherence
 ResolvedbtrahanT7578 Render username mentions in Conpherence in a disabled style if the user can not see the thread
 OpenNoneT7579 Notify users if their name is mentioned in a Conpherence thread they can see but are not a member of
 OpenNoneT7580 Alert users to username mentions in Conpherence threads they are members of
 OpenNoneT7567 Support sound in Conpherence
 ResolvedepriestleyT5369 Phabricator should play lots of sounds all the time to give the experience of an elusive, ineffable richness
 ResolvedchadT7380 Build icon-based room switcher for persistent chat pane
 DuplicateNoneT7014 Annouce Persistent Chat option in Conpherence
 ResolvedepriestleyT7529 Durable Column scrollbars be runnin wild (desktop)
 ResolvedbtrahanT7539 Dragging a file into Durable Column on /home/ triggers full upload
 ResolvedepriestleyT7058 Quicksand gets confused if you manually navigate to the original page
 ResolvedepriestleyT7063 Comment previews don't work in Quicksand
 ResolvedNoneT7061 Some UIs activate dialogs incorrectly when Quicksand is active
 ResolvedbtrahanT7064 Hi-Sec doesn't work properly with Quicksand
 ResolvedepriestleyT7059 Quicksand and the JX.busy navigation bar don't interact properly
Restricted Maniphest Task
 ResolvedbtrahanT7566 Implement "Rooms" in Conpherence
 ResolvedbtrahanT7585 Implement view/join rules for rooms
 ResolvedbtrahanT7582 Implement policies in Conpherence to support rooms
 ResolvedbtrahanT7583 Add a "room" flag to Conpherence

Event Timeline

epriestley created this task.Mar 16 2015, 9:09 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Conpherence.
epriestley added a subtask: T7582: Implement policies in Conpherence to support rooms.
epriestley added subscribers: joshuaspence, epriestley, btrahan, chad.
epriestley mentioned this in T7566: Implement "Rooms" in Conpherence.Mar 16 2015, 9:13 PM
epriestley moved this task from Backlog to v2 on the Conpherence board.Mar 16 2015, 9:41 PM
btrahan claimed this task.Mar 19 2015, 10:30 PM
btrahan added a revision: D12149: Conpherence - implement join / view rules for rooms.Mar 24 2015, 11:25 PM
btrahan added a commit: rP25767096c931: Conpherence - implement join / view rules for rooms.Mar 25 2015, 1:38 AM
btrahan added a comment.Mar 25 2015, 10:33 PM

Rough edges here

  • since rooms you have yet to join can't be viewed in the column yet, the column view has some bugs and isn't expected to work if you somehow get such a room in that view :D
  • in normal view, the room you're looking at is just pre-pending to the top of the "recent" list

If anyone has specific thoughts on these rough edges, let me know, else I figure they'll end up getting addressed as we figure out how to finish T7584. The column view piece might be significant though so leaving this one open for now mainly to track that.

btrahan closed this task as Resolved.Mar 26 2015, 11:50 PM

T7566 for any polish thoughts on this. :D

Ended up with the room you're in (even if not a participant yet) at the top of the list. No way to look at a room in column view you have yet to participate in.

btrahan closed subtask T7582: Implement policies in Conpherence to support rooms as Resolved.Apr 3 2015, 5:12 PM
Phabricator · Built by Phacility