Page MenuHomePhabricator

Conpherence - add application search in a few more places.
ClosedPublic

Authored by btrahan on Mar 30 2015, 11:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 10:00 AM
Unknown Object (File)
Sun, Dec 8, 4:05 PM
Unknown Object (File)
Fri, Dec 6, 5:42 PM
Unknown Object (File)
Sat, Nov 30, 1:42 AM
Unknown Object (File)
Tue, Nov 26, 6:06 PM
Unknown Object (File)
Fri, Nov 22, 3:47 AM
Unknown Object (File)
Nov 16 2024, 5:08 AM
Unknown Object (File)
Nov 12 2024, 12:12 PM
Subscribers

Details

Summary

Ref T7584. In Conpherence main view, this adds a "search" link right in the "Rooms" header. This piece addresses an outstanding item on T7584. This diff also adds a search button in the durable column that takes you to the application search. This kind of a big product bet that rooms are going to be dominating things and its most useful to find another room quickly from this view. That said, I think the application search should get massaged slightly to allow searching threads and this won't be much of a trade off at all.

Test Plan

verified new search links took me to correct place and displayed reasonably.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - add application search in a few more places..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/application/PhabricatorConpherenceApplication.php
40

Maybe just remove this route? We don't have any links to it now, right?

This revision is now accepted and ready to land.Mar 30 2015, 11:23 PM
This revision was automatically updated to reflect the committed changes.