Make the "result" property on Future private
ClosedPublic
Actions

Authored by epriestley on Feb 26 2020, 8:29 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARC4d55067fd87f: Make the "result" property on Future private

Summary

Depends on D21033. Ref T11968. This is just an incremental step in modernizing Future and making it more robust. Currently, subclasses are expected to write directly to $this->result, but this isn't consistent with how modern classes generally work.

Test Plan

Ran unit tests, created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

fx4

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23925
Build 32925: Run Core Tests
Build 32924: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 26 2020, 8:29 PM

Harbormaster completed remote builds in B23925: Diff 50104.Feb 26 2020, 8:30 PM

epriestley requested review of this revision.Feb 26 2020, 8:30 PM

epriestley added a child revision: D21035: Make "exception" on Future a private property.Feb 27 2020, 12:16 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2020, 5:18 PM

Closed by commit rARC4d55067fd87f: Make the "result" property on Future private (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC4d55067fd87f: Make the "result" property on Future private.

artms added a subscriber: artms.Apr 2 2020, 2:54 PM

artms added inline comments.

src/future/Future.php
103	This break drydock test runs, see https://secure.phabricator.com/harbormaster/build/32983/
103	PHP Fatal error: Cannot override final method Future::getResult() in /core/data/drydock/workingcopy-75/repo/phabricator/src/applications/harbormaster/future/HarbormasterExecFuture.php on line 50