Page MenuHomePhabricator

Remove all readers and all nontrivial writers for "accountType" and "accountDomain" on "ExternalAccount"
ClosedPublic

Authored by epriestley on Feb 22 2020, 10:29 PM.
Tags
None
Referenced Files
F13231314: D21019.id50065.diff
Tue, May 21, 12:22 AM
F13205734: D21019.diff
Wed, May 15, 2:19 AM
F13190206: D21019.id50082.diff
Sat, May 11, 8:18 AM
F13189760: D21019.diff
Sat, May 11, 6:21 AM
F13175840: D21019.id.diff
Wed, May 8, 7:53 AM
Unknown Object (File)
Tue, May 7, 10:06 AM
Unknown Object (File)
Fri, May 3, 10:10 AM
Unknown Object (File)
Mon, Apr 29, 5:09 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D21018. Ref T13493. Ref T6703. The "ExternalAccount" table has a unique key on <accountType, accountDomain, accountID> but this no longer matches our model of reality and changes in this sequence end writes to accountID.

Remove this key.

Then, remove all readers of accountType and accountDomain (and all nontrivial writers) because none of these callsites are well-aligned with plans in T6703.

This change has no user-facing impact today: all the rules about linking/unlinking/etc remain unchanged, because other rules currently prevent creation of more than one provider with a given "accountType".

Test Plan
  • Linked an OAuth1 account (JIRA).
  • Linked an OAuth2 account (Asana).
  • Used bin/auth refresh to cycle OAuth tokens.
  • Grepped for affected symbols.
  • Published an Asana update.
  • Published a JIRA link.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable