Page MenuHomePhabricator

Remove an ancient no-op check for duplicated external accounts
ClosedPublic

Authored by epriestley on Feb 21 2020, 12:11 AM.
Tags
None
Referenced Files
F13236557: D21012.diff
Tue, May 21, 10:08 AM
F13206719: D21012.diff
Wed, May 15, 4:46 PM
Unknown Object (File)
Tue, May 7, 1:11 PM
Unknown Object (File)
Mon, May 6, 4:44 AM
Unknown Object (File)
Sat, May 4, 12:08 AM
Unknown Object (File)
Thu, May 2, 7:53 AM
Unknown Object (File)
Wed, May 1, 10:14 AM
Unknown Object (File)
Sun, Apr 28, 11:32 AM
Subscribers
None

Details

Summary

Ref T13493. This check was introduced in D4647, but the condition can never be reached in modern Phabricator because the table has a unique key on <accountType, accountDomain, accountID> -- so no row can ever exist with the same value for that tuple but a different ID.

(I'm not entirely sure if it was reachable in D4647 either.)

Test Plan

Used SHOW CREATE TABLE to look at keys on the table and reasoned that this block can never have any effect.

Diff Detail

Repository
rP Phabricator
Branch
auth4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23880
Build 32856: Run Core Tests
Build 32855: arc lint + arc unit