Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 21, 4:18 PM
Unknown Object (File)
Fri, Apr 19, 3:17 AM
Unknown Object (File)
Fri, Apr 19, 3:17 AM
Unknown Object (File)
Fri, Apr 19, 3:17 AM
Unknown Object (File)
Wed, Apr 17, 8:55 PM
Unknown Object (File)
Thu, Apr 11, 7:29 AM
Unknown Object (File)
Thu, Apr 11, 4:26 AM
Unknown Object (File)
Tue, Apr 2, 11:33 PM
Subscribers
None

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Branch
elogin1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23155
Build 31799: Run Core Tests
Build 31798: arc lint + arc unit