Page MenuHomePhabricator

Move "Password Reset" email to "PeopleMailEngine"
ClosedPublic

Authored by epriestley on Jul 19 2019, 2:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 12:21 PM
Unknown Object (File)
Thu, Mar 14, 5:33 PM
Unknown Object (File)
Thu, Mar 14, 11:05 AM
Unknown Object (File)
Feb 26 2024, 8:15 AM
Unknown Object (File)
Feb 3 2024, 10:56 PM
Unknown Object (File)
Jan 24 2024, 11:54 PM
Unknown Object (File)
Jan 6 2024, 2:24 PM
Unknown Object (File)
Jan 6 2024, 3:55 AM
Subscribers
None

Details

Summary

Ref T13343. This makes "Password Reset" email a little more consistent with other modern types of email. My expectation is that this patch has no functional changes, just organizes code a little more consistently.

The new setRecipientAddress() mechanism deals with the case where the user types a secondary (but still verified) address.

Test Plan
  • Sent a normal "login with email" email.
  • Sent a "login with email to set password" email by trying to set a password on an account with no password yet.
  • Tried to email reset a bot account (no dice: they can't do web logins so this operation isn't valid).
  • Tested existing "PeopleMailEngine" subclasses:
    • Created a new user and sent a "welcome" email.
    • Renamed a user and sent a "username changed" email.
  • Reviewed all generated mail with bin/mail list-outbound.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable