Page MenuHomePhabricator

Allow users to be approved from the profile "Manage" page, alongside other similar actions
ClosedPublic

Authored by epriestley on Feb 7 2019, 3:08 PM.
Tags
None
Referenced Files
F12841262: D20123.diff
Thu, Mar 28, 9:04 PM
Unknown Object (File)
Tue, Mar 26, 1:59 PM
Unknown Object (File)
Tue, Mar 26, 1:05 PM
Unknown Object (File)
Tue, Mar 26, 1:04 PM
Unknown Object (File)
Tue, Mar 26, 1:03 PM
Unknown Object (File)
Feb 12 2024, 2:57 AM
Unknown Object (File)
Feb 3 2024, 9:14 PM
Unknown Object (File)
Feb 1 2024, 9:00 PM
Subscribers
None

Details

Summary

Depends on D20122. Fixes T8029. Adds an "Approve User" action to the "Manage" page.

Users are normally approved from the "Approval Queue", but if you click into a user's profile to check them out in more detail it kind of dead ends you right now. I've occasionally hit this myself, and think this workflow is generally reasonable enough to support upstream.

Test Plan

Screen Shot 2019-02-07 at 7.05.48 AM.png (854×1 px, 203 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
180–182

Maybe also (or alternatively) check for $is_admin and visually call out the "Not Approved" text in the header of this page? Or in the "Roles" property farther down the page.

This revision is now accepted and ready to land.Feb 7 2019, 8:51 PM

I also thought about putting a standalone "approve / reject" panel on the main profile page (not the "Manage" page), but I sort of want to modularize that at some point (so we can get a "member of instances: x, y" panel on admin.phacility.com) and don't want to make that any harder than it already is until that happens.

  • Pop those tags (visually, by giving them more color).
This revision was automatically updated to reflect the committed changes.