Details
- Reviewers
amckinley - Maniphest Tasks
- T13222: 2018 Week 48-51 Bonus Content
- Commits
- rP5e94343c7d1a: Add a garbage collector for MFA challenges
- Ran bin/garbage collect --collector ... and saw old MFA challenges collected.
- Triggered a new challenge, GC'd again, saw it survive GC while still active.
Diff Detail
- Repository
- rP Phabricator
- Branch
- mfa8
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21341 Build 29043: Run Core Tests Build 29042: arc lint + arc unit
Event Timeline
I don't want to go down a bike shedding path here, but I feel like keeping challenges for a ~week would put us in a better position the first time someone wants to debug this stuff.
Yeah -- I initially kept it for a week, but then I was like "it would be better to make that week configurable since it's kind of weird to hard-code it and there's support to make it configurable...", but that was kind of a bit more code and we'd end up with a mild mess removing it later since the configurable part gets stored in Config. I'd also guess there's a real possibility that we never actually look at this table to debug anything.
The GC normally only runs every ~4 hours so if someone reports a reproducible thing we'll probably be able to grab it even without a + 7 days thing as long as we're pretty quick about it and it's not a total phantom ghost thing.