Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor
ClosedPublic
Actions

Authored by epriestley on Aug 14 2018, 8:30 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13164: Plans: 2018 Week 31 - 33 Bonus Content

Commits

rP24d444584548: Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor

Summary

Depends on D19582. Ref T13164. It's not possible to reach the editor without passing through a CAN_EDIT check, and it shouldn't be necessarily to manually specify that edits require CAN_EDIT by default.

Test Plan

Grepped for RepositoryEditor, verified that all callsites pass through a CAN_EDIT check.

Diff Detail

Repository

rP Phabricator

Branch

uxaction6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20614
Build 28010: Run Core Tests
Build 28009: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 14 2018, 8:30 PM

Harbormaster completed remote builds in B20614: Diff 46814.Aug 14 2018, 8:31 PM

epriestley requested review of this revision.Aug 14 2018, 8:31 PM

epriestley added a child revision: D19584: Move the hierarchical edit policy check in Phriction from requireCapabilities() to validateTransactions().Aug 14 2018, 9:37 PM

amckinley accepted this revision.Aug 14 2018, 10:08 PM

This revision is now accepted and ready to land.Aug 14 2018, 10:08 PM

Closed by commit rP24d444584548: Remove pointless requireCapabilities() method from PhabricatorRepositoryEditor (authored by epriestley). · Explain WhyAug 16 2018, 5:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

editor/

PhabricatorRepositoryEditor.php

34 lines

Diff 46814

View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Remove pointless requireCapabilities() method from PhabricatorRepositoryEditorClosedPublicActions