Page MenuHomePhabricator
Differential D19291

Move PhabricatorModularTransaction slightly closer to having "final" methods again
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 5:04 PM.
Tags
None
Referenced Files
F15541789: D19291.id46157.diff
Fri, Apr 25, 1:32 PM
F15494852: D19291.diff
Sun, Apr 13, 1:54 AM
F15481941: D19291.id46157.diff
Wed, Apr 9, 1:02 AM
F15478266: D19291.id46173.diff
Mon, Apr 7, 9:44 PM
F15466911: D19291.id46173.diff
Thu, Apr 3, 10:44 AM
F15464363: D19291.id.diff
Wed, Apr 2, 8:53 AM
F15461459: D19291.diff
Tue, Apr 1, 8:27 AM
F15448165: D19291.diff
Mar 28 2025, 3:20 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits
rP592d72e00688: Move PhabricatorModularTransaction slightly closer to having "final" methods…
Summary

Depends on D19290. Ref T13110. Differential still has some hacks in place which require these methods to "very temporarily" be nonfinal, but the badness can be slightly reduced nowadays.

Test Plan

Loaded some pages, nothing fataled.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 3 2018, 5:04 PM
Harbormaster completed remote builds in B19978: Diff 46157.Apr 3 2018, 5:05 PM
epriestley requested review of this revision.Apr 3 2018, 5:05 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:14 PM
Closed by commit rP592d72e00688: Move PhabricatorModularTransaction slightly closer to having "final" methods… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
4 lines

Diff 46173

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
Phabricator · Built by Phacility