Differential D19288

When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not "Needs Review"
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 4:42 PM.

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rPf4f33113124f: When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not…

Summary

Depends on D19287. Ref T13110. Currently, "Abandon" and then "Reclaim" moves you out of "Draft" without setting the "Should Broadcast" flag. Keep these revisions in draft instead.

Test Plan

Reclaimed an abandoned + draft revision, got a draft revision instead of a "needs review + nonbroadcast" revision (which isn't a meaningful state).

Diff Detail

Repository

rP Phabricator

Branch

bengine11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19975
Build 27085: Run Core Tests
Build 27084: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 4:42 PM

Harbormaster completed remote builds in B19975: Diff 46154.Apr 3 2018, 4:43 PM

epriestley requested review of this revision.Apr 3 2018, 4:43 PM

epriestley added a child revision: D19289: When a draft's builds fail and it demotes to "Changes Planned + Draft", notify the author (only) via email.Apr 3 2018, 4:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:11 PM

Closed by commit rPf4f33113124f: When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionReclaimTransaction.php

8 lines

Diff 46154

View Options

src/applications/differential/xaction/DifferentialRevisionReclaimTransaction.php

When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not "Needs Review"ClosedPublicActions