Page MenuHomePhabricator
Differential D19287

When remote builds fail, demote revisions to "Changes Planned + But, Still A Draft"
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 4:28 PM.
Tags
None
Referenced Files
F13223808: D19287.diff
Sun, May 19, 5:02 AM
F13205803: D19287.diff
Wed, May 15, 2:23 AM
F13192032: D19287.id46153.diff
Sun, May 12, 4:17 AM
F13189880: D19287.diff
Sat, May 11, 6:31 AM
Unknown Object (File)
Tue, May 7, 10:14 AM
Unknown Object (File)
Fri, May 3, 1:32 PM
Unknown Object (File)
Fri, May 3, 10:20 AM
Unknown Object (File)
Thu, Apr 25, 3:47 AM
View All 76 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits
rPadf8fdef0e89: When remote builds fail, demote revisions to "Changes Planned + But, Still A…
Summary

Depends on D19286. Ref T13110. After builds fail remote builds, put revisions back in the author's queue.

This doesn't actually notify the author quite yet.

Test Plan

Made a failing build plan run on revisions, created a revision, saw it demote after builds failed.

Diff Detail

Repository
rP Phabricator
Branch
bengine10
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/differential/editor/DifferentialTransactionEditor.php:1594XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19974
Build 27083: Run Core Tests
Build 27082: arc lint + arc unit

Revision Contents
Changeset List

Diff 46153

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionActionTransaction.php

Loading...
View Options

src/applications/differential/xaction/DifferentialRevisionPlanChangesTransaction.php

Loading...
Phabricator · Built by Phacility