Differential D19286

When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review"
ClosedPublic
Actions

Authored by epriestley on Apr 3 2018, 3:56 PM.

Details

Reviewers: None
Maniphest Tasks: T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions
Commits: rPd9bd36039fd1: When a non-broadcasting revision is updated, put it in "Draft", not "Needs…

Summary

Depends on D19285. Ref T13110. When you update an "Abandoned + But, Never Promoted" revision or (in the future) a "Changes Planned + But, Never Promoted" revision, return it to the "Draft" state rather than promoting it.

Test Plan

Updated an "Abandoned + Draft" revision, saw it return to "Draft".

Diff Detail

Repository

rP Phabricator

Branch

bengine9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19973
Build 27081: Run Core Tests
Build 27080: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 3 2018, 3:56 PM

Harbormaster completed remote builds in B19973: Diff 46152.Apr 3 2018, 3:58 PM

epriestley requested review of this revision.Apr 3 2018, 3:58 PM

epriestley added a child revision: D19287: When remote builds fail, demote revisions to "Changes Planned + But, Still A Draft".Apr 3 2018, 4:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 3 2018, 6:10 PM

Closed by commit rPd9bd36039fd1: When a non-broadcasting revision is updated, put it in "Draft", not "Needs… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

xaction/

DifferentialRevisionUpdateTransaction.php

10 lines

Diff 46152

View Options

src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php

When a non-broadcasting revision is updated, put it in "Draft", not "Needs Review"ClosedPublicActions