Page MenuHomePhabricator
Differential D19142

Fix some of the most egregious errors in Harbormaster log paging
ClosedPublic
Actions

Authored by epriestley on Feb 27 2018, 1:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 9 2025, 5:33 AM
Unknown Object (File)
Feb 9 2025, 5:33 AM
Unknown Object (File)
Feb 9 2025, 5:33 AM
Unknown Object (File)
Feb 9 2025, 2:54 AM
Unknown Object (File)
Feb 5 2025, 12:13 PM
Unknown Object (File)
Jan 28 2025, 3:27 AM
Unknown Object (File)
Jan 26 2025, 9:43 PM
Unknown Object (File)
Jan 25 2025, 12:22 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPf450c6c55bfd: Fix some of the most egregious errors in Harbormaster log paging
Summary

Depends on D19141. Ref T13088. Some of the fundamental log behaviors like "loading the correct rows" are now a bit better behaved.

The UI is a little less garbage, too.

Test Plan

Viewed some logs and loaded more context by clicking the buttons.

Diff Detail

Repository
rP Phabricator
Branch
hlog12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19661
Build 26627: Run Core Tests
Build 26626: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2018, 1:49 AM
Owners added a subscriber: Restricted Owners Package.Feb 27 2018, 1:49 AM
Harbormaster completed remote builds in B19661: Diff 45850.Feb 27 2018, 1:51 AM
epriestley requested review of this revision.Feb 27 2018, 1:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:59 AM
Closed by commit rPf450c6c55bfd: Fix some of the most egregious errors in Harbormaster log paging (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
src/
applications/
harbormaster/
controller/
196 lines
webroot/
rsrc/
css/
application/
harbormaster/
64 lines
js/
application/
harbormaster/
4 lines

Diff 45850

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogRenderController.php

Loading...
View Options

webroot/rsrc/css/application/harbormaster/harbormaster.css

Loading...
View Options

webroot/rsrc/js/application/harbormaster/behavior-harbormaster-log.js

Loading...
Phabricator · Built by Phacility