Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 2:03 PM.

Details

Reviewers: None
Maniphest Tasks: T13088: Plans: Harbormaster UI usability and interconnectedness
Commits: rP46d735d312ca: Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`

Summary

Depends on D19136. Ref T13088. Since it's probably impractical to do all the migrations these changes imply during bin/storage upgrade, provide some support for performing them online.

Test Plan

Ran bin/harbormaster rebuild-log with --all, --id, and with and without --force.

Diff Detail

Repository

rP Phabricator

Branch

hlog8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19652
Build 26612: Run Core Tests
Build 26611: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 2:03 PM

Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 2:03 PM

Harbormaster completed remote builds in B19652: Diff 45843.Feb 23 2018, 2:04 PM

epriestley requested review of this revision.Feb 23 2018, 2:04 PM

epriestley added a child revision: D19138: Store the Harbormaster log chunk format on the log record.Feb 23 2018, 2:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:55 AM

Closed by commit rP46d735d312ca: Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log` (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

management/

HarbormasterManagementRebuildLogWorkflow.php

70 lines

Diff 45843

View Options

src/applications/harbormaster/management/HarbormasterManagementRebuildLogWorkflow.php

Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`ClosedPublicActions