Page MenuHomePhabricator
Differential D19136

In Harbormaster, record byte length on the build logs
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 1:52 PM.
Tags
None
Referenced Files
F15531137: D19136.id.diff
Wed, Apr 23, 9:51 AM
F15515572: D19136.id45842.diff
Fri, Apr 18, 11:31 AM
F15496812: D19136.id45842.diff
Sun, Apr 13, 8:12 AM
F15488157: D19136.id45857.diff
Thu, Apr 10, 7:55 PM
F15483565: D19136.id.diff
Wed, Apr 9, 1:07 PM
F15480157: D19136.diff
Tue, Apr 8, 12:17 PM
F15432633: D19136.diff
Mar 24 2025, 7:02 PM
F15431252: D19136.id45842.diff
Mar 24 2025, 11:18 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP57e3d607f566: In Harbormaster, record byte length on the build logs
Summary

Depends on D19135. Ref T13088. Denormalize the total log size onto the log itself. This makes reasoning about the log at display time easier, and we don't need to fish around in the database as much to figure out what we're dealing with.

Test Plan

Ran bin/harbormaster rebuild-log, saw an existing log populate. Ran bin/harbormaster write-log, saw new log write with proper length information.

Diff Detail

Repository
rP Phabricator
Branch
hlog7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19651
Build 26610: Run Core Tests
Build 26609: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 1:52 PM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:52 PM
Harbormaster completed remote builds in B19651: Diff 45842.Feb 23 2018, 1:53 PM
epriestley requested review of this revision.Feb 23 2018, 1:53 PM
epriestley added a child revision: D19137: Add "--all" and an explicit "--force" flag to `bin/harbormaster rebuild-log`.Feb 23 2018, 2:03 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:54 AM
Closed by commit rP57e3d607f566: In Harbormaster, record byte length on the build logs (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
harbormaster/
storage/
build/
33 lines
worker/
13 lines

Diff 45842

View Options

resources/sql/autopatches/20180223.log.01.bytelength.sql

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Loading...
Phabricator · Built by Phacility