Page MenuHomePhabricator
Differential D19134

Implement DestructibleInterface on BuildLog
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 1:18 PM.
Tags
None
Referenced Files
F18566637: D19134.id.diff
Tue, Sep 9, 2:47 PM
F18525729: D19134.id45840.diff
Sat, Sep 6, 3:42 PM
F18525728: D19134.id45855.diff
Sat, Sep 6, 3:42 PM
F18502219: D19134.diff
Thu, Sep 4, 10:17 PM
F18154992: D19134.id45840.diff
Thu, Aug 14, 9:03 PM
F18109910: D19134.diff
Mon, Aug 11, 3:25 PM
F17942812: D19134.id45840.diff
Jul 31 2025, 7:12 AM
F17857189: D19134.id45855.diff
Jul 27 2025, 6:11 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rPe920e2b143a2: Implement DestructibleInterface on BuildLog
Summary

Depends on D19133. Ref T13088. Allows build logs to be formally destroyed, cleaning up their chunks and file data.

Test Plan
  • Used bin/remove destroy to destroy a log, verified chunks and files were removed.
  • Used bin/harbormaster rebuild-log to force a log to rebuild, verified files were destroyed and regenerated.

Diff Detail

Repository
rP Phabricator
Branch
hlog5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19649
Build 26606: Run Core Tests
Build 26605: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 1:18 PM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 1:18 PM
Harbormaster completed remote builds in B19649: Diff 45840.Feb 23 2018, 1:19 PM
epriestley requested review of this revision.Feb 23 2018, 1:19 PM
epriestley added a child revision: D19135: Manage log locks on the Log object to prepare for multiple writers.Feb 23 2018, 1:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:53 AM
Closed by commit rPe920e2b143a2: Implement DestructibleInterface on BuildLog (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
harbormaster/
storage/
build/
54 lines
worker/
15 lines

Diff 45840

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterLogWorker.php

Loading...
Phabricator · Built by Phacility