Page MenuHomePhabricator
Differential D19133

Add a very basic standalone view for build logs with a "Download Log" button
ClosedPublic
Actions

Authored by epriestley on Feb 23 2018, 3:20 AM.
Tags
None
Referenced Files
F18808371: D19133.id.diff
Sun, Oct 19, 6:10 AM
F18806231: D19133.diff
Sat, Oct 18, 6:32 PM
F18779345: D19133.id45839.diff
Sat, Oct 11, 1:32 PM
F18764279: D19133.id.diff
Tue, Oct 7, 5:18 AM
F18753077: D19133.id45854.diff
Sat, Oct 4, 5:21 PM
F18649956: D19133.diff
Sat, Sep 20, 10:51 PM
F18647754: D19133.diff
Sep 19 2025, 2:52 PM
F18566634: D19133.id.diff
Sep 9 2025, 2:47 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13088: Plans: Harbormaster UI usability and interconnectedness
Commits
rP9b4295ed6051: Add a very basic standalone view for build logs with a "Download Log" button
Summary

Depends on D19132. Ref T13088. This implements an extremely skeletal dedicated log page with a more-or-less functional "Download Log" button.

Test Plan

Downloaded a recent log. Tried to download an old (un-finalized) log, couldn't. Used bin/harbormaster write-log to get a convenient standalone link to a log.

Diff Detail

Repository
rP Phabricator
Branch
hlog4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19648
Build 26604: Run Core Tests
Build 26603: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2018, 3:20 AM
Owners added a subscriber: Restricted Owners Package.Feb 23 2018, 3:20 AM
Harbormaster completed remote builds in B19648: Diff 45839.Feb 23 2018, 3:21 AM
epriestley requested review of this revision.Feb 23 2018, 3:21 AM
epriestley added a child revision: D19134: Implement DestructibleInterface on BuildLog.Feb 23 2018, 1:18 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 1:53 AM
Closed by commit rP9b4295ed6051: Add a very basic standalone view for build logs with a "Download Log" button (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45839

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogDownloadController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildLogViewController.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementWriteLogWorkflow.php

Loading...
View Options

src/applications/harbormaster/phid/HarbormasterBuildLogPHIDType.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/view/HarbormasterBuildLogView.php

Loading...
Phabricator · Built by Phacility