Page MenuHomePhabricator

When users resign from revisions, stop expanding projects/packages to include them

Authored by epriestley on Feb 7 2018, 4:08 PM.
Referenced Files
F12327762: D19021.diff
Sat, Dec 2, 2:30 PM
Unknown Object (File)
Thu, Nov 30, 12:29 AM
Unknown Object (File)
Sat, Nov 25, 6:20 PM
Unknown Object (File)
Wed, Nov 15, 7:39 AM
Unknown Object (File)
Oct 25 2023, 3:59 AM
Unknown Object (File)
Oct 24 2023, 5:32 AM
Unknown Object (File)
Oct 8 2023, 11:40 PM
Unknown Object (File)
Oct 1 2023, 7:03 AM



Depends on D19019. Ref T13053. Fixes T12689. See PHI178.

Currently, if @alice resigns from a revision but #alice-fan-club is still a subscriber or reviewer, she'll continue to get mail. This is undesirable.

When users are associated with an object but have explicitly disengaged in an individal role (currently, only resign in audit/differential) mark them "unexpandable", so that they can no longer be included through implicit membership in a group (a project or package).

@alice can still get mail if she's a explicit recipient: as an author, owner, or if she adds herself back as a subscriber.

Test Plan
  • Added @ducker and #users-named-ducker as reviewers. Ducker got mail.
  • Resigned as ducker, stopped getting future mail.
  • Subscribed explicitly, got mail again.
  • (Plus some var_dump() sanity checking in the internals.)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable