Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 1, 12:07 PM
Unknown Object (File)
Mon, Jun 30, 8:13 AM
Unknown Object (File)
Mon, Jun 30, 12:34 AM
Unknown Object (File)
Sun, Jun 29, 8:26 AM
Unknown Object (File)
Wed, Jun 18, 4:39 AM
Unknown Object (File)
Tue, Jun 17, 2:05 AM
Unknown Object (File)
Mon, Jun 16, 10:19 PM
Unknown Object (File)
Mon, Jun 16, 11:17 AM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Branch
mailer11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19376
Build 26202: Run Core Tests
Build 26201: arc lint + arc unit