Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 4:00 PM
Unknown Object (File)
Sat, Mar 23, 5:03 AM
Unknown Object (File)
Sat, Mar 23, 5:03 AM
Unknown Object (File)
Feb 15 2024, 1:17 PM
Unknown Object (File)
Jan 15 2024, 5:00 AM
Unknown Object (File)
Jan 15 2024, 4:58 AM
Unknown Object (File)
Jan 12 2024, 4:43 PM
Unknown Object (File)
Jan 12 2024, 1:30 AM
Subscribers
None

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Branch
mailer11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19376
Build 26202: Run Core Tests
Build 26201: arc lint + arc unit