Page MenuHomePhabricator

Remove all "originalTitle"/"originalName" fields from objects
ClosedPublic

Authored by epriestley on Feb 7 2018, 11:35 AM.

Details

Summary

Depends on D19012. Ref T13053. In D19012, I've changed "Thread-Topic" to always use PHIDs.

This change drops the selective on-object storage we have to track the original, human-readable title for objects.

Even if we end up backing out the "Thread-Topic" change, we'd be better off storing this in a table in the Mail app which just has <objectPHID, first subject we used when sending mail for that object>, since then we get the right behavior without needing every object to have this separate field.

Test Plan

Grepped for original, originalName, originalTitle, etc.

Diff Detail

Repository
rP Phabricator
Branch
mailer11
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 19376
Build 26202: Run Core Tests
Build 26201: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 7 2018, 11:35 AM
epriestley requested review of this revision.Feb 7 2018, 11:36 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 2:22 PM
This revision was automatically updated to reflect the committed changes.