Page MenuHomePhabricator

Support export of data in files larger than 8MB

Authored by epriestley on Jan 29 2018, 3:04 AM.
Referenced Files
Unknown Object (File)
Sat, May 20, 11:01 AM
Unknown Object (File)
Wed, May 10, 8:57 PM
Unknown Object (File)
Sun, May 7, 3:40 AM
Unknown Object (File)
Apr 2 2023, 4:03 PM
Unknown Object (File)
Apr 1 2023, 7:10 AM
Unknown Object (File)
Mar 16 2023, 3:26 AM
Unknown Object (File)
Feb 28 2023, 12:40 AM
Unknown Object (File)
Feb 7 2023, 11:43 AM



Depends on D18952. Ref T13049. For files larger than 8MB, we need to engage the chunk storage engine. PhabricatorFile::newFromFileData() always writes a single chunk, and can't handle files larger than the mandatory chunk threshold (8MB).

Use IteratorUploadSource, which can, and "stream" the data into it. This should raise the limit from 8MB to 2GB (maximum size of a string in PHP).

If we need to go above 2GB we could stream CSV and text pretty easily, and JSON without too much trouble, but Excel might be trickier. Hopefully no one is trying to export 2GB+ datafiles, though.

Test Plan
  • Changed the JSON exporter to just export 8MB of the letter "q": return str_repeat('q', 1024 * 1024 * 9);.
  • Before change: fatal, "no storage engine can store this file".
  • After change: export works cleanly.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable