HomePhabricator

Support export of data in files larger than 8MB

Description

Support export of data in files larger than 8MB

Summary:
Depends on D18952. Ref T13049. For files larger than 8MB, we need to engage the chunk storage engine. PhabricatorFile::newFromFileData() always writes a single chunk, and can't handle files larger than the mandatory chunk threshold (8MB).

Use IteratorUploadSource, which can, and "stream" the data into it. This should raise the limit from 8MB to 2GB (maximum size of a string in PHP).

If we need to go above 2GB we could stream CSV and text pretty easily, and JSON without too much trouble, but Excel might be trickier. Hopefully no one is trying to export 2GB+ datafiles, though.

Test Plan:

  • Changed the JSON exporter to just export 8MB of the letter "q": return str_repeat('q', 1024 * 1024 * 9);.
  • Before change: fatal, "no storage engine can store this file".
  • After change: export works cleanly.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13049

Differential Revision: https://secure.phabricator.com/D18953

Details

Provenance
epriestleyAuthored on Jan 29 2018, 2:47 AM
epriestleyPushed on Jan 29 2018, 11:58 PM
Reviewer
amckinley
Differential Revision
D18953: Support export of data in files larger than 8MB
Parents
rP0de6210808d7: Give data exporters a header row
Branches
Unknown
Tags
Unknown
Tasks
T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)
Build Status
Buildable 19261
Build 26028: Run Core Tests