Differential D18957

Make the data export format selector remember your last setting
ClosedPublic
Actions

Authored by epriestley on Jan 29 2018, 3:35 PM.

Tags

None

Referenced Files

	F14076341: D18957.id45456.diff
	Thu, Nov 21, 4:54 PM

	Unknown Object (File)
	Wed, Nov 20, 11:41 PM

	Unknown Object (File)
	Sat, Nov 16, 7:57 PM

	Unknown Object (File)
	Thu, Nov 14, 4:06 AM

	Unknown Object (File)
	Wed, Oct 23, 10:42 PM

	Unknown Object (File)
	Oct 14 2024, 6:45 PM

	Unknown Object (File)
	Oct 13 2024, 2:42 AM

	Unknown Object (File)
	Oct 1 2024, 12:09 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.)

Commits

rP61b8c12970be: Make the data export format selector remember your last setting

Summary

Depends on D18956. Ref T13049. Make the "Export Format" selector sticky.

This is partly selfish, since it makes testing format changes a bit easier.

It also seems like it's probably a good behavior in general: if you export to Excel once, that's probably what you're going to pick next time.

Test Plan

Exported to excel. Exported again, got excel as the default option.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 29 2018, 3:35 PM

Harbormaster completed remote builds in B19240: Diff 45456.Jan 29 2018, 3:36 PM

epriestley requested review of this revision.Jan 29 2018, 3:36 PM

epriestley added a child revision: D18958: When PHPExcel is not installed, detect it and provide install instructions.Jan 29 2018, 3:57 PM

Cool that this is so easy!

This revision is now accepted and ready to land.Jan 29 2018, 9:32 PM

This could probably be wrapped in something to make it a little slimmer if we start doing more of it, but I think we only have ~2-3 places where we do this right now (the other one that springs to mind is that we save projects you've recently used to set policies in the policy control).

Closed by commit rP61b8c12970be: Make the data export format selector remember your last setting (authored by epriestley). · Explain WhyJan 30 2018, 12:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

search/

controller/

PhabricatorApplicationSearchController.php

38 lines

infrastructure/

export/

engine/

PhabricatorExportFormatSetting.php

16 lines

Diff 45481

src/__phutil_library_map__.php

Loading...

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...

src/infrastructure/export/engine/PhabricatorExportFormatSetting.php

Loading...