Page MenuHomePhabricator

Remove the old, non-modular Excel export workflow from Maniphest
ClosedPublic

Authored by epriestley on Jan 29 2018, 4:59 PM.
Tags
None
Referenced Files
F13342382: D18961.diff
Thu, Jun 20, 12:46 PM
F13337421: D18961.diff
Wed, Jun 19, 9:33 AM
F13334142: D18961.diff
Tue, Jun 18, 5:24 PM
F13324902: D18961.diff
Sat, Jun 15, 1:06 AM
F13313490: D18961.diff
Tue, Jun 11, 7:58 AM
F13298146: D18961.diff
Fri, Jun 7, 6:22 AM
F13272129: D18961.diff
Thu, May 30, 7:58 AM
F13264612: D18961.diff
Mon, May 27, 7:19 PM
Subscribers
None

Details

Summary

Depends on D18960. Ref T13049. Now that Maniphest fully supports "Export Data", remove the old hard-coded version.

This is a backward compatibility break with the handful of installs that might have defined a custom export by subclassing ManiphestExcelFormat. I suspect this is almost zero installs, and that the additional data in the new format may serve most of the needs of this tiny number of installs. They can upgrade to ExportEngineExtensions fairly easily if this isn't true.

Test Plan
  • Viewed Maniphest, no longer saw the old export workflow.
  • Grepped for export and similar strings to try to hunt everything down.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable