Page MenuHomePhabricator

Allow "drydock.blueprint.edit" to create blueprints
ClosedPublic

Authored by epriestley on Dec 26 2017, 6:24 PM.
Tags
None
Referenced Files
F17948071: D18849.id.diff
Thu, Jul 31, 7:58 PM
F17942353: D18849.diff
Thu, Jul 31, 6:41 AM
F17940768: D18849.id45215.diff
Thu, Jul 31, 4:43 AM
F17937282: D18849.id45228.diff
Thu, Jul 31, 1:01 AM
F17878568: D18849.id45228.diff
Mon, Jul 28, 8:24 PM
F17832618: D18849.id45228.diff
Sat, Jul 26, 12:54 PM
F17825203: D18849.id.diff
Sat, Jul 26, 6:11 AM
F17794054: D18849.diff
Thu, Jul 24, 11:30 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D18848. Ref PHI243. This puts a bit of logic up front to figure out the blueprint type before we actually start editing it.

This implementation is a little messy but it keeps the API clean. Eventually, the implementation could probably go in the TransactionTypes so more code is shared, but I'd like to wait for a couple more of these first.

This capability probably isn't too useful, but just pays down a bit of technical debt from the caveat introduced in D18822.

Test Plan
  • Created a new blueprint with the API.
  • Tried to create a blueprint without a "type" (got a helpful error).
  • Created and edited blueprints via the web UI.
  • Tried to change the "type" of an existing blueprint (got a helpful error).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Dec 26 2017, 6:24 PM
This revision is now accepted and ready to land.Jan 2 2018, 7:03 PM
This revision was automatically updated to reflect the committed changes.