Page MenuHomePhabricator

Give EditEngine a Conduit-specific initialization pathway for objects
ClosedPublic

Authored by epriestley on Dec 26 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 6:35 PM
Unknown Object (File)
Tue, Nov 19, 5:08 AM
Unknown Object (File)
Tue, Nov 5, 4:20 PM
Unknown Object (File)
Sep 17 2024, 3:44 AM
Unknown Object (File)
Aug 30 2024, 6:33 PM
Unknown Object (File)
Aug 20 2024, 12:23 PM
Unknown Object (File)
Aug 9 2024, 2:34 AM
Unknown Object (File)
Jul 30 2024, 2:38 PM
Subscribers
None

Details

Summary

Depends on D18845. See PHI243 for context and more details.

Briefly, some objects need a "type" transaction (or something similar) very early on, and we can't generate their fields until we know the object type. Drydock blueprints are an example: a blueprint's fields depend on the blueprint's type.

In web interfaces, the workflow just forces the user to select a type first. For Conduit workflows, I think the cleanest approach is to proactively extract and apply type information before processing the request. This will make the implementation a little messier, but the API cleaner.

An alternative is to add more fields to the API, like a "type" field. This makes the implementation cleaner, but the API messier. I think we're better off favoring a cleaner API here.

This change just makes it possible for DrydockBlueprintEditEngine to look at the incoming transactions and extract a "type"; it doesn't actually change any behavior.

Test Plan

Performed edits via API, but this change doesn't alter any behavior.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable