HomePhabricator

Allow "drydock.blueprint.edit" to create blueprints

Description

Allow "drydock.blueprint.edit" to create blueprints

Summary:
Depends on D18848. Ref PHI243. This puts a bit of logic up front to figure out the blueprint type before we actually start editing it.

This implementation is a little messy but it keeps the API clean. Eventually, the implementation could probably go in the TransactionTypes so more code is shared, but I'd like to wait for a couple more of these first.

This capability probably isn't too useful, but just pays down a bit of technical debt from the caveat introduced in D18822.

Test Plan:

  • Created a new blueprint with the API.
  • Tried to create a blueprint without a "type" (got a helpful error).
  • Created and edited blueprints via the web UI.
  • Tried to change the "type" of an existing blueprint (got a helpful error).

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D18849

Details

Provenance
epriestleyAuthored on Dec 26 2017, 6:17 PM
epriestleyPushed on Jan 4 2018, 6:08 PM
Reviewer
amckinley
Differential Revision
D18849: Allow "drydock.blueprint.edit" to create blueprints
Parents
rP6d9776fa8963: Give EditEngine a Conduit-specific initialization pathway for objects
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19010
Build 25641: Run Core Tests