Paths

Table of Contentst

Differential D18845

Modularize transactions for Drydock Blueprints
ClosedPublic
Actions

Authored by epriestley on Dec 26 2017, 5:44 PM.

Tags

None

Referenced Files

	F15420955: D18845.id.diff
	Fri, Mar 21, 7:27 PM

	F15415921: D18845.diff
	Thu, Mar 20, 8:27 AM

	F15381143: D18845.id45226.diff
	Fri, Mar 14, 6:06 AM

	F15379257: D18845.id45211.diff
	Thu, Mar 13, 7:48 PM

	Unknown Object (File)
	Feb 13 2025, 1:33 PM

	Unknown Object (File)
	Feb 9 2025, 4:54 AM

	Unknown Object (File)
	Feb 9 2025, 4:54 AM

	Unknown Object (File)
	Feb 9 2025, 4:54 AM

Subscribers

Restricted Owners Package

Details

Reviewers

Commits

rP83c528c46435: Modularize transactions for Drydock Blueprints

Summary

Ref PHI243. This is a followup to D18822, which added an edit-only drydock.blueprint.edit. By modularizing transactions (here) and then adding a "type" transaction (next change) I intend to remove the "edit-only" limitation and make this API method fully functional.

Test Plan

Created and edited blueprints via the web UI. Edited blueprints via the API. Disabled/enabled blueprints (currently web UI only).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Dec 26 2017, 5:44 PM

Owners added a subscriber: Restricted Owners Package.Dec 26 2017, 5:44 PM

Harbormaster completed remote builds in B18990: Diff 45211.Dec 26 2017, 5:45 PM

epriestley requested review of this revision.Dec 26 2017, 5:45 PM

epriestley added a child revision: D18847: Give EditEngine a Conduit-specific initialization pathway for objects.Dec 26 2017, 5:53 PM

amckinley accepted this revision.Dec 26 2017, 11:47 PM

This revision is now accepted and ready to land.Dec 26 2017, 11:47 PM

Closed by commit rP83c528c46435: Modularize transactions for Drydock Blueprints (authored by epriestley). · Explain WhyJan 4 2018, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

8 lines

applications/

drydock/

controller/

DrydockBlueprintDisableController.php

3 lines

editor/

DrydockBlueprintEditEngine.php

2 lines

DrydockBlueprintEditor.php

100 lines

storage/

DrydockBlueprintTransaction.php

35 lines

xaction/

DrydockBlueprintDisableTransaction.php

48 lines

DrydockBlueprintNameTransaction.php

60 lines

DrydockBlueprintTransactionType.php

4 lines

Diff 45226

src/__phutil_library_map__.php

Loading...

src/applications/drydock/controller/DrydockBlueprintDisableController.php

Loading...

src/applications/drydock/editor/DrydockBlueprintEditEngine.php

Loading...

src/applications/drydock/editor/DrydockBlueprintEditor.php

Loading...

src/applications/drydock/storage/DrydockBlueprintTransaction.php

Loading...

src/applications/drydock/xaction/DrydockBlueprintDisableTransaction.php

Loading...

src/applications/drydock/xaction/DrydockBlueprintNameTransaction.php

Loading...

src/applications/drydock/xaction/DrydockBlueprintTransactionType.php

Loading...