(stable) Promote 2021 Week 21
Audit Required2124c8af6d2d
Actions

Description

(stable) Promote 2021 Week 21

Details

Group Auditors

Provenance

epriestley	Authored on May 22 2021, 12:38 PM
epriestley	Pushed on May 22 2021, 12:38 PM

Parents

rP95662ae8f1a7: Don't attempt to test capabilities on incomplete handles
rP2afedad61c51: (stable) Skip "git for-each-ref" when identifying deleted commits

Branches

Unknown

Tags

Unknown

Build Status

Buildable 25362
Build 35016: Run Core Tests

Event Timeline

epriestley committed rP2124c8af6d2d: (stable) Promote 2021 Week 21 (authored by epriestley).May 22 2021, 12:38 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMay 22 2021, 12:39 PM

This commit now requires audit.May 22 2021, 12:39 PM

Harbormaster completed building B25362: rP2124c8af6d2d: (stable) Promote 2021 Week 21.May 22 2021, 12:40 PM

Merged Changes

95662ae8f1a7 Don't attempt to test capabilities on incomplete handles
Author
epriestley
Revisions
D21662: Don't attempt to test capabilities on incomplete handles
Browse Repository
Passed
No Audits
1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Revisions
D21654: Update client logic for inline comment "Save" and "Cancel" actions
Browse Repository
Passed
No Audits
6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Revisions
D21653: Formally track "initial", "committed", and "active" states for inline comments
Browse Repository
Passed
No Audits
b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Revisions
D21652: When creating an inline comment, populate the content state with the default suggestion text
Browse Repository
Passed
No Audits
5efe7fb4c181 On inline comments, track an explicit "committed" content state
Author
epriestley
Revisions
D21651: On inline comments, track an explicit "committed" content state
Browse Repository
Passed
No Audits
428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Revisions
D21650: Fix an issue when undoing mutiple inline comment deletions
Browse Repository
Passed
No Audits
d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Revisions
D21649: Make the client authoritative for "Cancel" actions
Browse Repository
Passed
No Audits
60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Revisions
D21648: Make the client authoritative for "Save" actions
Browse Repository
Passed
No Audits
0f04d9e58458 Remove direct reads of form state from main Inline client code
Author
epriestley
Revisions
D21647: Remove direct reads of form state from main Inline client code
Browse Repository
Passed
No Audits
cb00cb99e244 Make client inlines track an "active" state
Author
epriestley
Revisions
D21646: Make client inlines track an "active" state
Browse Repository
Passed
No Audits
b964731b6a6b Make inline "ContentState" a client object, and track "hasSuggestion" on it
Author
epriestley
Revisions
D21645: Make inline "ContentState" a client object, and track "hasSuggestion" on it
Browse Repository
Passed
No Audits
87c6c270b435 Fix an issue where inlines could be duplicated in the client list
Author
epriestley
Revisions
D21642: Fix an issue where inlines could be duplicated in the client list
Browse Repository
Passed
No Audits
aa70b008f3a1 Skip "git for-each-ref" when identifying deleted commits
Author
epriestley
Revisions
D21658: Skip "git for-each-ref" when identifying deleted commits
Browse Repository
Passed
No Audits
5b8b5f214148 Correct issue with "bindings" conduit attachment
Author
epriestley
Revisions
D21657: Correct issue with "bindings" conduit attachment
Browse Repository
Passed
No Audits

Changes (14)

Path

Size

resources/

celerity/

map.php

packages.php

src/

applications/

differential/

render/

DifferentialChangesetRenderer.php

phid/

PhabricatorObjectHandle.php

infrastructure/

diff/

PhabricatorInlineCommentController.php

interface/

PhabricatorInlineComment.php

view/

PHUIDiffInlineCommentEditView.php

PHUIDiffInlineCommentRowScaffold.php

PHUIDiffInlineCommentUndoView.php

PHUIDiffInlineCommentView.php

webroot/

rsrc/

externals/

javelin/

lib/

Resource.js

js/

application/

diff/

DiffChangeset.js

DiffInline.js

DiffInlineContentState.js

rP2124c8af6d2d

View Options

resources/celerity/map.php

View Options

resources/celerity/packages.php

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/phid/PhabricatorObjectHandle.php

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

View Options

src/infrastructure/diff/interface/PhabricatorInlineComment.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentRowScaffold.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php

View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

View Options

webroot/rsrc/externals/javelin/lib/Resource.js

View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

View Options

webroot/rsrc/js/application/diff/DiffInline.js

View Options

webroot/rsrc/js/application/diff/DiffInlineContentState.js

(stable) Promote 2021 Week 21Audit Required2124c8af6d2dActions

Description

Details

Event Timeline

Merged Changes

Changes (14)

rP2124c8af6d2d

resources/celerity/map.php

resources/celerity/packages.php

src/applications/differential/render/DifferentialChangesetRenderer.php

src/applications/phid/PhabricatorObjectHandle.php

src/infrastructure/diff/PhabricatorInlineCommentController.php

src/infrastructure/diff/interface/PhabricatorInlineComment.php

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentRowScaffold.php

src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

webroot/rsrc/externals/javelin/lib/Resource.js

webroot/rsrc/js/application/diff/DiffChangeset.js

webroot/rsrc/js/application/diff/DiffInline.js

webroot/rsrc/js/application/diff/DiffInlineContentState.js

(stable) Promote 2021 Week 21
Audit Required2124c8af6d2d
Actions