(stable) Promote 2015 Week 52
3dbc1418ff07
Actions

Description

(stable) Promote 2015 Week 52

Details

Provenance

epriestley	Authored on
epriestley	Pushed on Dec 26 2015, 11:20 AM

Differential Revision

D14573: Add a linter rule for use of `is_a`

Parents

rARCb3e68c9f1793: Add a linter rule for use of `is_a`
rARC05ac4a67e22e: (stable) Promote 2015 Week 49

Branches

Unknown

Tags

Unknown

Build Status

Buildable 9802
Build 11788: Run Core Tests

Event Timeline

epriestley committed rARC3dbc1418ff07: (stable) Promote 2015 Week 52 (authored by epriestley).Dec 26 2015, 11:19 AM

Harbormaster completed building B9802: rARC3dbc1418ff07: (stable) Promote 2015 Week 52.Dec 26 2015, 11:20 AM

Merged Changes

b3e68c9f1793 Add a linter rule for use of `is_a`
Author
joshuaspence
Revisions
D14573: Add a linter rule for use of `is_a`
Browse Repository
Passed
No Audits
9ee14d28490c Improve the "self member reference" linter rule
Author
joshuaspence
Revisions
D13935: Improve the "self member reference" linter rule
Browse Repository
Passed
No Audits
8762e3f36715 Use "--whitespace nowarn" in `arc patch` to respect trailing whitespace
Author
epriestley
Revisions
D14816: Use "--whitespace nowarn" in `arc patch` to respect trailing whitespace
Browse Repository
Passed
No Audits
a183c2c4ba58 When `arc` is run with `--trace`, print out argv explicitly
Author
epriestley
Revisions
D14797: When `arc` is run with `--trace`, print out argv explicitly
Browse Repository
Passed
No Audits
9a373c88d747 Explain how to move forward or backward from `arc land --hold`
Author
epriestley
Revisions
D14762: Explain how to move forward or backward from `arc land --hold`
Browse Repository
Passed
No Audits
7d25fcdbdb51 Simplify diff exit code handling.
Author
dim
Revisions
D14759: Simplify diff exit code handling.
Browse Repository
Passed
No Audits
97056a3b85bb Preserve the exit code of the diff command in binary_safe_diff.sh
Author
dim
Revisions
D14755: Preserve the exit code of the diff command in binary_safe_diff.sh
Browse Repository
Passed
No Audits
74c7495b1a92 Clarify that "arc land" means it is merging changes, not branch refences
Author
epriestley
Revisions
D14754: Clarify that "arc land" means it is merging changes, not branch refences
Browse Repository
Passed
No Audits
dae2f0073f01 In `arc diff`, try to guess where a change should land
Author
epriestley
Revisions
D14736: In `arc diff`, try to guess where a change should land
Browse Repository
Passed
No Audits
d0e73bb65610 Don't use "-c" flag in "git:branch-unique()" revision range rule
Author
epriestley
Revisions
D14735: Don't use "-c" flag in "git:branch-unique()" revision range rule
Browse Repository
Passed
No Audits
0c8124a2729d Fix handling of empty array index
Author
joshuaspence
Browse Repository
Passed
Audited
d2e778549727 Add a linter rule for curly brace array indexes
Author
joshuaspence
Revisions
D14603: Add a linter rule for curly brace array indexes
Browse Repository
Passed
No Audits
a6e81daad1bb Improve brace formatting linter rule
Author
joshuaspence
Revisions
D14690: Improve brace formatting linter rule
Browse Repository
Passed
No Audits
b52e9dc702c2 Linter fixes
Author
joshuaspence
Revisions
D14633: Linter fixes
Browse Repository
Passed
No Audits

Changes (51)

Path

Size

scripts/

arcanist.php

repository/

binary_safe_diff.sh

src/

__phutil_library_map__.php

land/

ArcanistGitLandEngine.php

lint/

linter/

xhpast/

rules/

ArcanistBraceFormattingXHPASTLinterRule.php

ArcanistClassFilenameMismatchXHPASTLinterRule.php

ArcanistCurlyBraceArrayIndexXHPASTLinterRule.php

ArcanistImplicitFallthroughXHPASTLinterRule.php

ArcanistIsAShouldBeInstanceOfXHPASTLinterRule.php

ArcanistKeywordCasingXHPASTLinterRule.php

ArcanistPaamayimNekudotayimSpacingXHPASTLinterRule.php

ArcanistSelfClassReferenceXHPASTLinterRule.php

ArcanistSelfMemberReferenceXHPASTLinterRule.php

__tests__/

	ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php
	ArcanistDuplicateKeysInArrayXHPASTLinterRuleTestCase.php

	ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php
	ArcanistObjectOperatorSpacingXHPASTLinterRuleTestCase.php

ArcanistPaamayimNekudotayimSpacingXHPASTLinterRuleTestCase.php

ArcanistSelfClassReferenceXHPASTLinterRuleTestCase.php

brace-formatting/

brace-formatting.lint-test

class.lint-test

control-statement.lint-test

declare.lint-test

function.lint-test

try-catch.lint-test

curly-brace-array-index

array.lint-test

nested.lint-test

whitespace.lint-test

is_a-should-be-instanceof

allow_string.lint-test

is_a.lint-test

keyword-casing/

parent.lint-test

self.lint-test

paamayim-nekudotayim-spacing

comment.lint-test

newline.lint-test

paamayim-nekudotayim-spacing.lint-test

self-class-reference

self-class-references.lint-test

self-member-reference/

php54.lint-test

self-member-reference.lint-test

	xhpast/	rules/	__tests__/	curly-brace-array-index/
			__tests__/	xhpast/

	array_push.lint-test
	no-segfault-on-exit.lint-test

parser/

ArcanistBaseCommitParser.php

repository/

api/

ArcanistGitAPI.php

ArcanistMercurialAPI.php

ArcanistSubversionAPI.php

unit/

engine/

NoseTestEngine.php

PytestTestEngine.php

workflow/

ArcanistDiffWorkflow.php

ArcanistFlagWorkflow.php

ArcanistLandWorkflow.php

ArcanistPatchWorkflow.php

rARC3dbc1418ff07

View Options

scripts/arcanist.php

View Options

scripts/repository/binary_safe_diff.sh

View Options

src/__phutil_library_map__.php

View Options

src/land/ArcanistGitLandEngine.php

View Options

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistClassFilenameMismatchXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistCurlyBraceArrayIndexXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistImplicitFallthroughXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistIsAShouldBeInstanceOfXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistKeywordCasingXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistPaamayimNekudotayimSpacingXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistPaamayimNekudotayimSpacingXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/ArcanistSelfClassReferenceXHPASTLinterRuleTestCase.php

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/brace-formatting.lint-test

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/class.lint-test

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/control-statement.lint-test

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/declare.lint-test

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/function.lint-test

View Options

src/lint/linter/xhpast/rules/tests/brace-formatting/try-catch.lint-test

View Options

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/array.lint-test

View Options

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/array_push.lint-test

View Options

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/nested.lint-test

View Options

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/whitespace.lint-test

View Options

src/lint/linter/xhpast/rules/tests/is_a-should-be-instanceof/allow_string.lint-test

View Options

src/lint/linter/xhpast/rules/tests/is_a-should-be-instanceof/is_a.lint-test

View Options

src/lint/linter/xhpast/rules/tests/keyword-casing/parent.lint-test

View Options

src/lint/linter/xhpast/rules/tests/keyword-casing/self.lint-test

View Options

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/comment.lint-test

View Options

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/newline.lint-test

View Options

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/paamayim-nekudotayim-spacing.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-member-reference/php54.lint-test

View Options

src/lint/linter/xhpast/rules/tests/self-member-reference/self-member-reference.lint-test

View Options

src/parser/ArcanistBaseCommitParser.php

View Options

src/repository/api/ArcanistGitAPI.php

View Options

src/repository/api/ArcanistMercurialAPI.php

View Options

src/repository/api/ArcanistSubversionAPI.php

View Options

src/unit/engine/NoseTestEngine.php

View Options

src/unit/engine/PytestTestEngine.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistFlagWorkflow.php

View Options

src/workflow/ArcanistLandWorkflow.php

View Options

src/workflow/ArcanistPatchWorkflow.php

(stable) Promote 2015 Week 523dbc1418ff07Actions

Description

Details

Event Timeline

Merged Changes

Changes (51)

rARC3dbc1418ff07

scripts/arcanist.php

scripts/repository/binary_safe_diff.sh

src/__phutil_library_map__.php

src/land/ArcanistGitLandEngine.php

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistClassFilenameMismatchXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistCurlyBraceArrayIndexXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistImplicitFallthroughXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistIsAShouldBeInstanceOfXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistKeywordCasingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistPaamayimNekudotayimSpacingXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfClassReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/__tests__/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistPaamayimNekudotayimSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/ArcanistSelfClassReferenceXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/__tests__/brace-formatting/brace-formatting.lint-test

src/lint/linter/xhpast/rules/__tests__/brace-formatting/class.lint-test

src/lint/linter/xhpast/rules/__tests__/brace-formatting/control-statement.lint-test

src/lint/linter/xhpast/rules/__tests__/brace-formatting/declare.lint-test

src/lint/linter/xhpast/rules/__tests__/brace-formatting/function.lint-test

src/lint/linter/xhpast/rules/__tests__/brace-formatting/try-catch.lint-test

src/lint/linter/xhpast/rules/__tests__/curly-brace-array-index/array.lint-test

src/lint/linter/xhpast/rules/__tests__/curly-brace-array-index/array_push.lint-test

src/lint/linter/xhpast/rules/__tests__/curly-brace-array-index/nested.lint-test

src/lint/linter/xhpast/rules/__tests__/curly-brace-array-index/whitespace.lint-test

src/lint/linter/xhpast/rules/__tests__/is_a-should-be-instanceof/allow_string.lint-test

src/lint/linter/xhpast/rules/__tests__/is_a-should-be-instanceof/is_a.lint-test

src/lint/linter/xhpast/rules/__tests__/keyword-casing/parent.lint-test

src/lint/linter/xhpast/rules/__tests__/keyword-casing/self.lint-test

src/lint/linter/xhpast/rules/__tests__/paamayim-nekudotayim-spacing/comment.lint-test

src/lint/linter/xhpast/rules/__tests__/paamayim-nekudotayim-spacing/newline.lint-test

src/lint/linter/xhpast/rules/__tests__/paamayim-nekudotayim-spacing/paamayim-nekudotayim-spacing.lint-test

src/lint/linter/xhpast/rules/__tests__/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/__tests__/self-member-reference/php54.lint-test

src/lint/linter/xhpast/rules/__tests__/self-member-reference/self-member-reference.lint-test

src/parser/ArcanistBaseCommitParser.php

src/repository/api/ArcanistGitAPI.php

src/repository/api/ArcanistMercurialAPI.php

src/repository/api/ArcanistSubversionAPI.php

src/unit/engine/NoseTestEngine.php

src/unit/engine/PytestTestEngine.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistFlagWorkflow.php

src/workflow/ArcanistLandWorkflow.php

src/workflow/ArcanistPatchWorkflow.php

(stable) Promote 2015 Week 52
3dbc1418ff07
Actions

src/lint/linter/xhpast/rules/tests/ArcanistCurlyBraceArrayIndexXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistIsAShouldBeInstanceOfXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistPaamayimNekudotayimSpacingXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/ArcanistSelfClassReferenceXHPASTLinterRuleTestCase.php

src/lint/linter/xhpast/rules/tests/brace-formatting/brace-formatting.lint-test

src/lint/linter/xhpast/rules/tests/brace-formatting/class.lint-test

src/lint/linter/xhpast/rules/tests/brace-formatting/control-statement.lint-test

src/lint/linter/xhpast/rules/tests/brace-formatting/declare.lint-test

src/lint/linter/xhpast/rules/tests/brace-formatting/function.lint-test

src/lint/linter/xhpast/rules/tests/brace-formatting/try-catch.lint-test

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/array.lint-test

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/array_push.lint-test

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/nested.lint-test

src/lint/linter/xhpast/rules/tests/curly-brace-array-index/whitespace.lint-test

src/lint/linter/xhpast/rules/tests/is_a-should-be-instanceof/allow_string.lint-test

src/lint/linter/xhpast/rules/tests/is_a-should-be-instanceof/is_a.lint-test

src/lint/linter/xhpast/rules/tests/keyword-casing/parent.lint-test

src/lint/linter/xhpast/rules/tests/keyword-casing/self.lint-test

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/comment.lint-test

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/newline.lint-test

src/lint/linter/xhpast/rules/tests/paamayim-nekudotayim-spacing/paamayim-nekudotayim-spacing.lint-test

src/lint/linter/xhpast/rules/tests/self-class-reference/self-class-references.lint-test

src/lint/linter/xhpast/rules/tests/self-member-reference/php54.lint-test

src/lint/linter/xhpast/rules/tests/self-member-reference/self-member-reference.lint-test