Simplify diff exit code handling.
7d25fcdbdb51
Actions

Description

Simplify diff exit code handling.

Summary:
This fixes T9970 in an alternate manner, with the same effect: the
binary_safe_diff.sh script returns 0 if the diff succeeds, 1 in all
other cases.

Test Plan:
Tested locally with a fixed binary_safe_diff.sh, resulting in this
correct review:

https://reviews.freebsd.org/D4542

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: eadler, Korvin, stevenh

Maniphest Tasks: T9970

Differential Revision: https://secure.phabricator.com/D14759

Details

Provenance

dim	Authored on
epriestley	Committed on Dec 13 2015, 10:35 AM
epriestley	Pushed on Dec 13 2015, 10:35 AM

Reviewer

Blessed Reviewers

Differential Revision

D14759: Simplify diff exit code handling.

Parents

rARC97056a3b85bb: Preserve the exit code of the diff command in binary_safe_diff.sh

Branches

Unknown

Tags

Unknown

Tasks

T9970: new files are empty for arc diff --create and --update

Build Status

Buildable 9510
Build 11341: Run Core Tests

Event Timeline

epriestley committed rARC7d25fcdbdb51: Simplify diff exit code handling. (authored by dim).Dec 13 2015, 10:35 AM

epriestley added a task: T9970: new files are empty for arc diff --create and --update .

Harbormaster completed building B9510: rARC7d25fcdbdb51: Simplify diff exit code handling..Dec 13 2015, 10:35 AM

Changes (1)

Path

Size

scripts/

repository/

binary_safe_diff.sh

rARC7d25fcdbdb51

View Options

scripts/repository/binary_safe_diff.sh