User Details
User Details
- User Since
- Dec 12 2015, 6:08 AM (568 w, 6 d)
- Availability
- Available
Dec 13 2015
Dec 13 2015
dim added a revision to T9970: new files are empty for arc diff --create and --update : Unknown Object (Differential Revision).
Dec 12 2015
Dec 12 2015
dim added a comment to T9970: new files are empty for arc diff --create and --update .
Right, I think I have found the cause. The binary_safe_diff.sh does not preserve the exit code of diff, and it returns 0 even if diff returned 1. Apparently returning 0 causes Subversion 1.9 to emit the file headers again.
dim added a comment to T9970: new files are empty for arc diff --create and --update .
For me this gives:
dim added a comment to T9970: new files are empty for arc diff --create and --update .
Hmm, this seems to be caused by Subversion 1.9 (which is the default in the FreeBSD ports collection). If I use Subversion 1.8 to run the svn diff --depth empty --diff-cmd '/usr/local/lib/php/arcanist/scripts/repository/binary_safe_diff.sh' -x -U32767 foo.txt command, the output is:
dim updated subscribers of T9970: new files are empty for arc diff --create and --update .
Adding Eitan, since he's our Phabricator wrangler.
dim added a comment to T9970: new files are empty for arc diff --create and --update .
I think the problem is because of Subversion automatic properties. For the FreeBSD Subversion repository, automatic properties get added, like this: