Page MenuHomePhabricator
Differential D14690

Improve brace formatting linter rule
ClosedPublic
Actions

Authored by joshuaspence on Dec 7 2015, 10:33 AM.
Tags
None
Referenced Files
F17675954: D14690.diff
Sun, Jul 13, 9:33 AM
Unknown Object (File)
Jun 1 2025, 12:23 PM
Unknown Object (File)
May 30 2025, 5:07 AM
Unknown Object (File)
May 29 2025, 8:44 AM
Unknown Object (File)
May 28 2025, 2:11 PM
Unknown Object (File)
May 10 2025, 5:14 AM
Unknown Object (File)
May 10 2025, 5:14 AM
Unknown Object (File)
May 10 2025, 5:13 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCa6e81daad1bb: Improve brace formatting linter rule
Summary

Allow the brace formatting linter rule to complain about class X{}.

Test Plan

Updated unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 35528.Dec 7 2015, 10:33 AM
joshuaspence retitled this revision from to Improve brace formatting linter rule.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 7 2015, 10:33 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 7 2015, 12:36 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 7 2015, 12:36 PM
Closed by commit rARCa6e81daad1bb: Improve brace formatting linter rule (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 7 2015, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
lint/
linter/
xhpast/
rules/
8 lines
__tests__/
brace-formatting/
14 lines
53 lines
4 lines
27 lines
14 lines

Diff 35547

View Options

src/lint/linter/xhpast/rules/ArcanistBraceFormattingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/brace-formatting.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/class.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/control-statement.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/declare.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/function.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/brace-formatting/try-catch.lint-test

Loading...
Phabricator · Built by Phacility