Page MenuHomePhabricator

DivinerProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Documentation generator.

Recent Activity

Apr 6 2020

epriestley closed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given" as Resolved.

I deployed D21062, and the three examples in the original report look good now. I checked about a dozen other pages and couldn't find anything else broken; let me know if I missed anything. Thanks for the report!

Apr 6 2020, 7:02 PM · Diviner
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21062: Refine handling of "@task" attributes in Diviner.
Apr 6 2020, 6:50 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

The second issue is that the API still returns a string when there is exactly one @attribute of a given type. This is a bit goofy; PhutilExecChannel is another example case.

Apr 6 2020, 6:47 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

I deployed D21061. First two example pages are good now, third one is hitting a different error. New trace is:

Apr 6 2020, 6:45 PM · Diviner
epriestley added a revision to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given": D21061: Update DivinerAtomController for a long-ago change to the docblock parser API.
Apr 6 2020, 6:21 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Docblocks may have multiple copies of the same @attribute directive, like this:

Apr 6 2020, 6:19 PM · Diviner
epriestley claimed T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Apr 6 2020, 6:11 PM · Diviner
epriestley added a comment to T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".

Here's the full stack trace:

Apr 6 2020, 6:11 PM · Diviner
aklapper created T13505: Some Diviner pages on secure.phabricator.com show "RuntimeException: strlen() expects parameter 1 to be string, array given".
Apr 6 2020, 2:36 PM · Diviner

May 23 2019

epriestley edited projects for T9825: Remarkup is rendered literally in Diviner, added: Diviner; removed Remarkup.
May 23 2019, 2:45 PM · Diviner

Dec 17 2018

epriestley renamed T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing] from User documentation on "secure" is occasionally unpublishing to Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
Dec 17 2018, 3:45 PM · Diviner

Oct 31 2018

epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The immediate issue now appears fixed and it seems likely that the root cause is also fixed. We should still hunt down the bad cache behavior in the presence of wonky permissions.

Oct 31 2018, 3:42 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

This cropped up again and the permissions error also resurfaced, even though I previously nuked the directory.

Oct 31 2018, 3:21 PM · Diviner

Oct 5 2018

epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

For now, I just hard-wiped the cache and regenerated the documentation again. ¯\_(ツ)_/¯

Oct 5 2018, 4:15 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The file cache says that these files have already been parsed and contain no atoms, so the rest of the program behavior is expected after that. I'm not sure how this state came to exist.

Oct 5 2018, 4:03 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
  • DivinerPublisher->publishAtoms() is being passed nothing, so it's correctly deleting everything.
  • The graph cache is empty.
  • The actual atom.cache file on disk is empty.
  • The input to the cache is empty.
  • The files aren't being passed to the atomizer rules (although the rules appear to be applying correctly).
Oct 5 2018, 3:36 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

So, so far it looks like the database is in a "good" state but the publish workflow incorrectly deleted all the articles. From previous efforts, I believe dropping the cache fixes this issue.

Oct 5 2018, 3:26 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

But note that the graphHash and nodeHash columns are 0, which I believe is a signal that these nodes have been deleted (I haven't touched this code in a while).

Oct 5 2018, 3:21 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

Oh, the contrib stuff got separated into a different book and has fully unpublished:

Oct 5 2018, 1:27 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The "Contributor Introduction" document, specifically, seems to have unpublished. Let me see what I can dig up about the current database state.

Oct 5 2018, 1:14 PM · Diviner

Sep 27 2018

epriestley triaged T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing] as Normal priority.
Sep 27 2018, 1:01 PM · Diviner

Jan 26 2018

epriestley added a comment to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.

I think a reasonable path forward here is for Diviner to have a {symbol} sort of syntax which executes a symbol index query. The symbol index can already be configured to know how to offer links to external documentation.

Jan 26 2018, 3:14 PM · Restricted Project, Symbols, Diviner
epriestley renamed T8533: Allow Diviner to fall back to (or link directly to) the Symbol index from Allow linking to external documentation to Allow Diviner to fall back to (or link directly to) the Symbol index.
Jan 26 2018, 3:07 PM · Restricted Project, Symbols, Diviner

Jan 24 2018

epriestley closed T8536: Merge symbols and Diviner, a subtask of T4558: Make Diviner useful for third-parties, as Wontfix.
Jan 24 2018, 4:42 PM · Diviner
epriestley closed T8536: Merge symbols and Diviner as Wontfix.

Per above, I think the pathway forward here is probably "tighter integration", not "merge/replace", i.e. tools for Diviner to automatically update Symbols, too. I'm just going to conceptually roll this up into T13047.

Jan 24 2018, 4:41 PM · Symbols, Diviner
epriestley closed T8536: Merge symbols and Diviner, a subtask of T8533: Allow Diviner to fall back to (or link directly to) the Symbol index, as Wontfix.
Jan 24 2018, 4:41 PM · Restricted Project, Symbols, Diviner
epriestley added a parent task for T8536: Merge symbols and Diviner: T13047: Plans: Symbol Indexes.
Jan 24 2018, 4:25 PM · Symbols, Diviner

Aug 24 2017

chad added a comment to T823: Add image support to Diviner.

Embedding files by alias might be useful

Aug 24 2017, 2:59 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

Oh I see the problem with that

Aug 24 2017, 2:58 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

I've been locally previewing in Phriction.

Aug 24 2017, 2:22 PM · Diviner
epriestley added a comment to T823: Add image support to Diviner.

I'd guess it's several days of work.

Aug 24 2017, 2:21 PM · Diviner
chad added a comment to T823: Add image support to Diviner.

Is this hard to do? Can me accomplish?

Aug 24 2017, 1:55 PM · Diviner

Jul 9 2017

chad set the image for Diviner to F5039273: profile.
Jul 9 2017, 7:32 PM

Apr 25 2017

chad closed T12637: ToC button icon in Diviner and Phriction isn't centered? as Resolved by committing rP279816683b17: Move ToC 4px in documentproview.
Apr 25 2017, 5:50 PM · Phriction, Diviner, Design
chad added a revision to T12637: ToC button icon in Diviner and Phriction isn't centered?: D17790: Move ToC 4px in documentproview.
Apr 25 2017, 5:48 PM · Phriction, Diviner, Design

Apr 24 2017

epriestley created T12637: ToC button icon in Diviner and Phriction isn't centered?.
Apr 24 2017, 4:29 PM · Phriction, Diviner, Design

Apr 7 2017

arielyang updated Q607: How to set help link of self-host Phabricator to local url. from to How to set help link of self-host Phabricator to local url..
Apr 7 2017, 3:08 AM · Diviner

Feb 14 2017

faulconbridge added a comment to T12258: Diviner atom document status inverted when searching.

+1 for random grepping. Thanks for the fix!

Feb 14 2017, 1:00 PM · Diviner, Bug Report
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

(Your diagnosis of the root cause was also correct.)

Feb 14 2017, 12:05 PM · Diviner, Bug Report
epriestley added a comment to T12258: Diviner atom document status inverted when searching.

I deployed D17346 and rebuilt the indexes on this install with bin/search index --type DivinerLiveSymbol and behavior now seems correct. Thanks for the report!

Feb 14 2017, 12:05 PM · Diviner, Bug Report

Feb 13 2017

epriestley closed T12258: Diviner atom document status inverted when searching as Resolved by committing rP6f37685a7589: Fix flipped open/closed status for Diviner atoms in search index.
Feb 13 2017, 9:12 PM · Diviner, Bug Report
epriestley added a project to T12258: Diviner atom document status inverted when searching: Diviner.
Feb 13 2017, 9:08 PM · Diviner, Bug Report

Dec 14 2016

epriestley closed T12015: Unable to resolve method 'describeAutomaticCapability'. as Resolved by committing rPae0e97a49974: Remove unusual explicit calls to policy capability descriptions from Diviner.
Dec 14 2016, 7:23 PM · Diviner, Bug Report
epriestley added a revision to T12015: Unable to resolve method 'describeAutomaticCapability'.: D17056: Remove unusual explicit calls to policy capability descriptions from Diviner.
Dec 14 2016, 7:04 PM · Diviner, Bug Report
epriestley added a comment to T12015: Unable to resolve method 'describeAutomaticCapability'..

I think the major intent was being able to edit "View Policy" so you could create private documentation, but I don't recall if we got that far.

Dec 14 2016, 7:00 PM · Diviner, Bug Report
chad added a comment to T12015: Unable to resolve method 'describeAutomaticCapability'..

You could tag a project I think, but not sure what that actually did.

Dec 14 2016, 6:18 PM · Diviner, Bug Report
avivey added a project to T12015: Unable to resolve method 'describeAutomaticCapability'.: Diviner.

Basically nobody is using Diviner, and I don't think the "Edit Book" page actually does anything useful.

Dec 14 2016, 6:00 PM · Diviner, Bug Report

Aug 5 2016

eadler added a project to T8533: Allow Diviner to fall back to (or link directly to) the Symbol index: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Symbols, Diviner

Jul 22 2016

lewellyn added a comment to T9042: Diviner fails to create all books, path is error.

I see the same behavior noted by @lianghu in T9042#129510.

Jul 22 2016, 5:15 AM · Diviner

May 12 2016

epriestley closed T10958: Dead Link at Diviner as Resolved by committing rP0faf3dd18d73: Fix "Contributing" misspelling in documentation.
May 12 2016, 3:30 PM · Documentation, Diviner, Bug Report