Page MenuHomePhabricator
Feed Advanced Search

Apr 18 2020

epriestley added a revision to T13515: Differential: Inlines and View Options: Restricted Differential Revision.
Apr 18 2020, 10:24 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Restricted Differential Revision.
Apr 18 2020, 9:31 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Unknown Object (Differential Revision).
Apr 18 2020, 6:34 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Unknown Object (Differential Revision).
Apr 18 2020, 6:25 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Unknown Object (Differential Revision).
Apr 18 2020, 4:56 PM · Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): Unknown Object (Differential Revision).
Apr 18 2020, 4:48 PM · Diffusion, Differential
epriestley renamed T13516: Remove the "filetree" setting (so it's always enabled for everyone) from Remove the "filetree" setting to Remove the "filetree" setting (so it's always enabled for everyone).
Apr 18 2020, 4:48 PM · Diffusion, Differential
epriestley added a comment to T13455: Make "View Options" in Differential sticky across reloads.

To save this setting, the shortest path is to just reload the change with an option like justSaveViewStateDoNotActuallyRenderAnything=true. But, since reloading changes is per-changeset, this is inefficient if filetree changes out of T13516 support collapsing multiple files at once.

Apr 18 2020, 3:09 PM · Differential
epriestley triaged T13516: Remove the "filetree" setting (so it's always enabled for everyone) as Low priority.
Apr 18 2020, 2:51 PM · Diffusion, Differential

Apr 17 2020

epriestley added a revision to T13455: Make "View Options" in Differential sticky across reloads: Unknown Object (Differential Revision).
Apr 17 2020, 11:18 PM · Differential
epriestley added a comment to T13455: Make "View Options" in Differential sticky across reloads.

Updating renderer is a big oof. The value sometimes depends on the window dimensions on the client.

Apr 17 2020, 10:29 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 17 2020, 8:54 PM · Differential
epriestley added a revision to T13455: Make "View Options" in Differential sticky across reloads: Unknown Object (Differential Revision).
Apr 17 2020, 8:16 PM · Differential
epriestley updated the task description for T13178: Plans: Support Pact Competitive Update.
Apr 17 2020, 7:04 PM · Plans, Support, Phacility
epriestley added a comment to T13455: Make "View Options" in Differential sticky across reloads.

There is currently no storage unique to a <user, changeset> pair, or a <user, diff> pair, or a <user, revision> pair.

Apr 17 2020, 6:20 PM · Differential
epriestley updated the task description for T13514: Restore the Differential "minimap" element.
Apr 17 2020, 5:58 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 17 2020, 5:49 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Unknown Object (Differential Revision).
Apr 17 2020, 5:32 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 17 2020, 5:00 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: Unknown Object (Differential Revision).
Apr 17 2020, 4:52 PM · Differential
epriestley added a comment to T13515: Differential: Inlines and View Options.

keyboard shortcut for "Open in Editor".

Apr 17 2020, 3:27 PM · Differential
epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 17 2020, 3:13 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 17 2020, 3:13 PM · Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 17 2020, 3:13 PM · Differential
epriestley added a parent task for T13513: Make schema changes to inlines to prepare for new inline features: T13515: Differential: Inlines and View Options.
Apr 17 2020, 3:11 PM · Inline Comments, Diffusion, Differential
epriestley added a parent task for T13455: Make "View Options" in Differential sticky across reloads: T13515: Differential: Inlines and View Options.
Apr 17 2020, 3:11 PM · Differential
epriestley added a parent task for T13514: Restore the Differential "minimap" element: T13515: Differential: Inlines and View Options.
Apr 17 2020, 3:11 PM · Differential
epriestley added subtasks for T13515: Differential: Inlines and View Options: T13514: Restore the Differential "minimap" element, T13513: Make schema changes to inlines to prepare for new inline features, T13455: Make "View Options" in Differential sticky across reloads.
Apr 17 2020, 3:11 PM · Differential
epriestley triaged T13515: Differential: Inlines and View Options as Normal priority.
Apr 17 2020, 3:11 PM · Differential
epriestley triaged T13514: Restore the Differential "minimap" element as Low priority.
Apr 17 2020, 3:10 PM · Differential
epriestley triaged T13513: Make schema changes to inlines to prepare for new inline features as Normal priority.
Apr 17 2020, 3:08 PM · Inline Comments, Diffusion, Differential
epriestley closed T13512: Owners Packages are missing "closed" state in tokenizers as Resolved by committing Restricted Diffusion Commit.
Apr 17 2020, 1:18 PM · Owners
epriestley added a revision to T13512: Owners Packages are missing "closed" state in tokenizers: Unknown Object (Differential Revision).
Apr 17 2020, 1:13 PM · Owners
epriestley triaged T13512: Owners Packages are missing "closed" state in tokenizers as Wishlist priority.
Apr 17 2020, 1:09 PM · Owners
epriestley renamed T13501: Improve search index normalization of "é" and other characters with variants or multiple representations from Ngram search for "é" has slicing and collation issues with multibyte characters and multicharacter glyphs to Improve search index normalization of "é" and other characters with variants or multiple representations.
Apr 17 2020, 1:05 PM · Search
epriestley closed T13508: In Chrome, the menu bar hover animation can cycle very rapidly if you put your cursor exactly on the bottom as Resolved by committing Restricted Diffusion Commit.
Apr 17 2020, 1:03 PM · Design
epriestley added a revision to T13508: In Chrome, the menu bar hover animation can cycle very rapidly if you put your cursor exactly on the bottom: Unknown Object (Differential Revision).
Apr 17 2020, 12:47 PM · Design
epriestley closed T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed as Resolved by committing Restricted Diffusion Commit.
Apr 17 2020, 12:38 PM · Paste, Installing & Upgrading
epriestley added a revision to T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed: Restricted Differential Revision.
Apr 17 2020, 12:34 PM · Paste, Installing & Upgrading
epriestley added a comment to T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed.

I think I'm just going to no-op this migration.

Apr 17 2020, 12:28 PM · Paste, Installing & Upgrading
epriestley closed T13511: Allow extensions to define new document fields (like "title:") in Ferret search as Resolved.

This is now possible.

Apr 17 2020, 12:23 PM · Search
epriestley closed T13503: Index Paste documents in Ferret as Resolved.

This is now supported.

Apr 17 2020, 12:23 PM · Search, Paste
epriestley closed T13503: Index Paste documents in Ferret, a subtask of T13511: Allow extensions to define new document fields (like "title:") in Ferret search, as Resolved.
Apr 17 2020, 12:23 PM · Search

Apr 16 2020

epriestley added a revision to T13511: Allow extensions to define new document fields (like "title:") in Ferret search: Unknown Object (Differential Revision).
Apr 16 2020, 8:39 PM · Search
epriestley added a comment to T13511: Allow extensions to define new document fields (like "title:") in Ferret search.

These field functions have somewhat-weird scopes/context.

Apr 16 2020, 6:08 PM · Search
epriestley added a revision to T13511: Allow extensions to define new document fields (like "title:") in Ferret search: Unknown Object (Differential Revision).
Apr 16 2020, 5:31 PM · Search
epriestley added a revision to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: Unknown Object (Differential Revision).
Apr 16 2020, 4:38 PM · Search
epriestley added a revision to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: Unknown Object (Differential Revision).
Apr 16 2020, 4:32 PM · Search
epriestley added a revision to T13511: Allow extensions to define new document fields (like "title:") in Ferret search: Unknown Object (Differential Revision).
Apr 16 2020, 3:05 PM · Search
epriestley added a parent task for T13503: Index Paste documents in Ferret: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search, Paste
epriestley added a parent task for T13501: Improve search index normalization of "é" and other characters with variants or multiple representations: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search
epriestley added subtasks for T13511: Allow extensions to define new document fields (like "title:") in Ferret search: T13509: Support "field present" and "field absent" operators in Ferret, T13503: Index Paste documents in Ferret, T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.
Apr 16 2020, 3:05 PM · Search
epriestley added a parent task for T13509: Support "field present" and "field absent" operators in Ferret: T13511: Allow extensions to define new document fields (like "title:") in Ferret search.
Apr 16 2020, 3:05 PM · Search
epriestley triaged T13511: Allow extensions to define new document fields (like "title:") in Ferret search as Normal priority.
Apr 16 2020, 3:04 PM · Search
epriestley added a comment to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.

Getting through the ngram index alone isn't good enough, because LIKE operators against utf8mb4_unicode_ci treat combining accents as separate characters:

Apr 16 2020, 2:59 PM · Search
epriestley added a comment to T13501: Improve search index normalization of "é" and other characters with variants or multiple representations.

Normalizer requires intl which I'm hesitant to add a dependency on.

Apr 16 2020, 2:00 PM · Search

Apr 15 2020

epriestley closed T13507: Compress Conduit client requests as Resolved.

One possible improvement remains here: in streaming mode, HTTPSFuture will not "Accept-Encoding: gzip" and can not inflate responses. Today, this only applies to arc download.

Apr 15 2020, 6:58 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 6:35 PM · Performance, Conduit
epriestley triaged T13510: Migration "20160223.paste.fileedges.php" fails after the "Paste" database was renamed as Wishlist priority.
Apr 15 2020, 6:05 PM · Paste, Installing & Upgrading
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 12:28 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 15 2020, 12:16 PM · Performance, Conduit

Apr 14 2020

epriestley added a comment to T13507: Compress Conduit client requests.

There's also one minor related concern in PHI1638 that I want to take care of here, since it's adjacent.

Apr 14 2020, 11:52 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:47 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:45 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 11:21 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 9:52 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

In fairness, "SetInputFilter DEFLATE" is documented as uniquely opinionated, if you catch this box and read between the lines a little bit:

Apr 14 2020, 9:45 PM · Performance, Conduit
epriestley added a comment to T13507: Compress Conduit client requests.

A grand aventure in PHI1679 led to identifying the Apache "SetInputFilter DEFLATE" directive as a problem with implementing compression.

Apr 14 2020, 9:40 PM · Performance, Conduit
epriestley added a revision to T13507: Compress Conduit client requests: Unknown Object (Differential Revision).
Apr 14 2020, 9:25 PM · Performance, Conduit
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 14 2020, 7:47 PM · Arcanist
epriestley closed T13509: Support "field present" and "field absent" operators in Ferret as Resolved.

This appears to be working properly, now.

Apr 14 2020, 6:19 PM · Search
epriestley added a comment to T13509: Support "field present" and "field absent" operators in Ferret.

Query parsing of certain unusual or ambiguous inputs has changed slightly.

Apr 14 2020, 5:31 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:31 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:23 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:22 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:18 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 5:03 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 4:56 PM · Search
epriestley added a revision to T13509: Support "field present" and "field absent" operators in Ferret: Unknown Object (Differential Revision).
Apr 14 2020, 4:52 PM · Search
epriestley triaged T13509: Support "field present" and "field absent" operators in Ferret as Low priority.
Apr 14 2020, 4:48 PM · Search

Apr 13 2020

epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 10:02 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 9:50 PM · Arcanist
epriestley created P2134 Command-Line Input.
Apr 13 2020, 9:13 PM
epriestley created P2133 Command-Line Input.
Apr 13 2020, 9:12 PM
epriestley created P2132 Command-Line Input.
Apr 13 2020, 9:11 PM
epriestley created P2131 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley created P2130 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley created P2129 Command-Line Input.
Apr 13 2020, 9:10 PM
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 9:09 PM · Arcanist, Installing & Upgrading
epriestley created P2128 (An Untitled Masterwork).
Apr 13 2020, 9:08 PM
epriestley created P2127 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2126 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2125 (An Untitled Masterwork).
Apr 13 2020, 9:07 PM
epriestley created P2124 (An Untitled Masterwork).
Apr 13 2020, 9:03 PM
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Apr 13 2020, 8:42 PM · Arcanist, Installing & Upgrading
epriestley closed T13203: Arcanist Wilds Patch Notes (Ongoing) as Resolved.

wilds and experimental have mostly collapsed together into master, and this is survived by T13488.

Apr 13 2020, 7:36 PM · Arcanist, Plans
epriestley closed T13203: Arcanist Wilds Patch Notes (Ongoing), a subtask of T13098: Plans: Arcanist toolsets and extensions, as Resolved.
Apr 13 2020, 7:36 PM · Arcanist, Plans
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 7:00 PM · Arcanist
epriestley added a revision to T13490: Upgrade all "classic" Arcanist workflows to Toolsets: Unknown Object (Differential Revision).
Apr 13 2020, 6:39 PM · Arcanist
epriestley added a comment to T13490: Upgrade all "classic" Arcanist workflows to Toolsets.

These are in better shape now:

Apr 13 2020, 6:18 PM · Arcanist