Applied this diff on my test install, panels confirmed unhaunted.

In T5554#134045, @jbeta wrote:

To make it still work out of the box with most potential users of insteadOf, we could use either command depending on git version if you think that's worth the hassle.

Implemented this approach in D13998.

In T5554#133958, @chandru wrote:

D13983 breaks on users running RHEL6. There git version is 1.7.1 and git 1.7.1 does not support --get-url option for ls-remote.

Those were all the cases of parsing git environment-dependent output I could find in arc (unless built-in formats like git log --format=medium are susceptible to git-config/localization/future change, which I doubt).

(Whoops, failed to find this one. Sorry.)

Should be more robust now.

• Switched strategy to parsing branch refs instead of relying on git "short" formats

Turned out, (test) is a valid branch name in git.

Rebased against master

It seems you also need both display_errors and display_startup_errors turned on to hit this, though. I don't know if that is something you'd want to support.

Well, due to recent shortages of warm expressions of user gratitude, the upstream has had to resort to providing their own positive feedback. They achieve this by self-awarding cool-looking badges for commits.

I just hit problem (2) on this report myself, had to trace it the same way @aelam did.

• Keep previous behavior in the case where origin does not exist.

In T5554#133477, @epriestley wrote:

I think this tactic (re-run the command to figure out the error) is a really fragile one and would be very hesitant to pursue it over requiring users to install locales, but agree on this otherwise.

Yes, it would be a desperate measure with a lot of problems of its own.

(Sorry I hadn't seen T7339, certainly makes my last comment mostly redundant. Perhaps the tasks can be merged?)

I think the current Phabricator/Arcanist handling of locales, at least on Linux, is wrong. The LANG environment variable has lower priority than the family of LC_* variables, as per POSIX §8.2:

(also there's a typo in the badge name :p)

Got it. In general, the rest of the code relies on an untranslated $this->branchType. I suppose that should be solved in a more general diff.

• Made the entire message block translatable
• Fixed switch indentation

Hmm... still, @avivey should be right in that $this->branchType makes the complete message not translatable, no?

Fair enough then, I'll update this.

Wouldn't that be harder to translate later on?

In T9225#133080, @chad wrote:

We'll even give you badge

(On a less important note, confirmed fixed for us in HEAD. Thanks for the quick response.)